linux-kernel - RE: [PATCH 2/6] media: i2c: imx334: Convert to CCI register access helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR11MB56117EBAD3A022E6E89B0F4981D12@PH0PR11MB5611.namprd11.prod.outlook.com>
Date: Tue, 11 Mar 2025 09:59:30 +0000
From: <Shravan.Chippa@...rochip.com>
To: <sakari.ailus@...ux.intel.com>
CC: <laurent.pinchart@...asonboard.com>, <tarang.raval@...iconsignals.io>,
	<kieran.bingham@...asonboard.com>, <mchehab@...nel.org>,
	<hverkuil@...all.nl>, <umang.jain@...asonboard.com>, <zhi.mao@...iatek.com>,
	<julien.massot@...labora.com>, <mike.rudenko@...il.com>,
	<benjamin.mugnier@...s.st.com>, <linux-media@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/6] media: i2c: imx334: Convert to CCI register access
 helpers

Hi Sakari ,

> -----Original Message-----
> From: Sakari Ailus <sakari.ailus@...ux.intel.com>
> Sent: Tuesday, March 11, 2025 3:17 PM
> To: shravan Chippa - I35088 <Shravan.Chippa@...rochip.com>
> Cc: laurent.pinchart@...asonboard.com; tarang.raval@...iconsignals.io;
> kieran.bingham@...asonboard.com; mchehab@...nel.org;
> hverkuil@...all.nl; umang.jain@...asonboard.com; zhi.mao@...iatek.com;
> julien.massot@...labora.com; mike.rudenko@...il.com;
> benjamin.mugnier@...s.st.com; linux-media@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH 2/6] media: i2c: imx334: Convert to CCI register access
> helpers
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Hi Shravan, Tarang,
> 
> On Tue, Mar 11, 2025 at 06:51:48AM +0000, Shravan.Chippa@...rochip.com
> wrote:
> > Hi Laurent,
> >
> > > -----Original Message-----
> > > From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > > Sent: Tuesday, March 11, 2025 12:09 PM
> > > To: shravan Chippa - I35088 <Shravan.Chippa@...rochip.com>
> > > Cc: tarang.raval@...iconsignals.io; sakari.ailus@...ux.intel.com;
> > > kieran.bingham@...asonboard.com; mchehab@...nel.org;
> > > hverkuil@...all.nl; umang.jain@...asonboard.com;
> > > zhi.mao@...iatek.com; julien.massot@...labora.com;
> > > mike.rudenko@...il.com; benjamin.mugnier@...s.st.com;
> > > linux-media@...r.kernel.org; linux- kernel@...r.kernel.org
> > > Subject: Re: [PATCH 2/6] media: i2c: imx334: Convert to CCI register
> > > access helpers
> > >
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > > know the content is safe
> > >
> > > Hi Shravan,
> > >
> > > On Tue, Mar 11, 2025 at 06:14:28AM +0000,
> > > Shravan.Chippa@...rochip.com
> > > wrote:
> > > > Hi Tarang,
> > > >
> > > > Thanks for the patch series with CCI register access helpers on
> > > > top of my patches I have tested (1080p,720p, 480p resolution only)
> > > > and working on my board with small PLL changes to make it
> > > > compatible with pfsoc board (mpfs-video-kit).
> > >
> > > Could you please provide more information about what those PLL
> > > changes are ?
> >
> > Here is the change for mpfs-video-kit board.
> >
> > diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
> > index 375367314416..30470dbd1f3c 100644
> > --- a/drivers/media/i2c/imx334.c
> > +++ b/drivers/media/i2c/imx334.c
> > @@ -236,9 +236,9 @@ static const struct cci_reg_sequence
> common_mode_regs[] = {
> >         { IMX334_REG_XVS_XHS_OUTSEL, 0x20},
> >         { IMX334_REG_XVS_XHS_DRV, 0x0f},
> >         { IMX334_REG_BCWAIT_TIME, 0x3b},
> > -       { IMX334_REG_CPWAIT_TIME, 0x2a},
> > +       { IMX334_REG_CPWAIT_TIME, 0x29},
> 
> A patch converting the driver to use V4L2 CCI / human-readable register
> names should not change the values written.
> 
> This change is exactly the same than your 2nd patch does. It'd be good to
> understand why it is different and what is effect of that difference.
> 
> >         { IMX334_REG_INCKSEL1, 0x0129},
> > -       { IMX334_REG_INCKSEL2, 0x06},
> > +       { IMX334_REG_INCKSEL2, 0x0a},
> 
> This is a bigger change indeed.
> 
> >         { IMX334_REG_INCKSEL3, 0xa0},
> >         { IMX334_REG_INCKSEL4, 0x7e},
> >         { IMX334_REG_SYS_MODE, 0x02},

Whatever I have send is as per the data sheet. This should work on other board

As per my understanding these changes are pfsoc mpfs-video-kit specific.
The video pipeline is not able to process the data very fast, this change will make 
incoming stream little slow, so that video pipeline will not hang.

Thanks,
Shravan
> 
> --
> Regards,
> 
> Sakari Ailus