linux-kernel - Re: (subset) [PATCH v2 0/6] Fixes multiple sysctl bound checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174165505001.528513.14421854436163772182.b4-ty@oracle.com>
Date: Mon, 10 Mar 2025 21:19:06 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-scsi@...r.kernel.org, codalist@...a.cs.cmu.edu,
        linux-nfs@...r.kernel.org, nicolas.bouchinet@...p-os.org
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
        Nicolas Bouchinet <nicolas.bouchinet@....gouv.fr>,
        Clemens Ladisch <clemens@...isch.de>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        Jan Harkes <jaharkes@...cmu.edu>, Chuck Lever <chuck.lever@...cle.com>,
        Jeff Layton <jlayton@...nel.org>, Neil Brown <neilb@...e.de>,
        Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>,
        Tom Talpey <tom@...pey.com>, Trond Myklebust <trondmy@...nel.org>,
        Anna Schumaker <anna@...nel.org>, Bart Van Assche <bvanassche@....org>,
        Zhu Yanjun <yanjun.zhu@...ux.dev>, Al Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>,
        Joel Granados <joel.granados@...nel.org>
Subject: Re: (subset) [PATCH v2 0/6] Fixes multiple sysctl bound checks

On Mon, 24 Feb 2025 10:58:15 +0100, nicolas.bouchinet@...p-os.org wrote:

> This patchset adds some bound checks to sysctls to avoid negative
> value writes.
> 
> The patched sysctls were storing the result of the proc_dointvec
> proc_handler into an unsigned int data. proc_dointvec being able to
> parse negative value, and it return value being a signed int, this could
> lead to undefined behaviors.
> This has led to kernel crash in the past as described in commit
> 3b3376f222e3 ("sysctl.c: fix underflow value setting risk in vm_table")
> 
> [...]

Applied to 6.15/scsi-queue, thanks!

[4/6] sysctl: Fixes scsi_logging_level bounds
      https://git.kernel.org/mkp/scsi/c/2cef5b4472c6

-- 
Martin K. Petersen	Oracle Linux Engineering