linux-kernel - Re: [PATCH V7 2/4] media: i2c: imx334: common reg value correction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN3P287MB1829A883F503B5D3EA2533E98BD12@PN3P287MB1829.INDP287.PROD.OUTLOOK.COM>
Date: Tue, 11 Mar 2025 10:09:21 +0000
From: Tarang Raval <tarang.raval@...iconsignals.io>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>, shravan kumar
	<shravan.chippa@...rochip.com>
CC: "mchehab@...nel.org" <mchehab@...nel.org>,
	"kieran.bingham@...asonboard.com" <kieran.bingham@...asonboard.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"conor.dooley@...rochip.com" <conor.dooley@...rochip.com>,
	"valentina.fernandezalanis@...rochip.com"
	<valentina.fernandezalanis@...rochip.com>, "praveen.kumar@...rochip.com"
	<praveen.kumar@...rochip.com>
Subject: Re: [PATCH V7 2/4] media: i2c: imx334: common reg value correction

Hi Sakari,

> On Wed, Mar 05, 2025 at 10:44:40AM +0530, shravan kumar wrote:
> > From: Shravan Chippa <shravan.chippa@...rochip.com>
> >
> > correcting the CPWAIT_TIME value as per the data sheet
> > for the link frequency and input clock
> >
> > Signed-off-by: Shravan Chippa <shravan.chippa@...rochip.com>
> 
> I've postponed applying this one once we have a better understanding what
> that change actually is and why Tarang would seem to want to revert it.

No, please recheck; I am not reverting this patch.

You can go ahead and apply this patch.

Best Regards,
Tarang 

> > ---
> >  drivers/media/i2c/imx334.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
> > index db61b298ceb3..0b42bc0470a1 100644
> > --- a/drivers/media/i2c/imx334.c
> > +++ b/drivers/media/i2c/imx334.c
> > @@ -191,7 +191,7 @@ static const struct imx334_reg common_mode_regs[] = {
> >       {0x31a0, 0x20},
> >       {0x31a1, 0x0f},
> >       {0x300c, 0x3b},
> > -     {0x300d, 0x29},
> > +     {0x300d, 0x2a},
> >       {0x314c, 0x29},
> >       {0x314d, 0x01},
> >       {0x315a, 0x06},
> 
> --
> Kind regards,
> 
> Sakari Ailus