linux-kernel - Re: [PATCH] ALSA: hda/realtek: Limit Internal Microphone boost for ALC3246

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tt7zyhon.wl-tiwai@suse.de>
Date: Tue, 11 Mar 2025 11:39:52 +0100
From: Takashi Iwai <tiwai@...e.de>
To: chester.a.unal@...nc9.com,
	"Chester A. Unal via B4 Relay" <devnull+chester.a.unal.arinc9.com@...nel.org>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Kailang Yang <kailang@...ltek.com>,
	Stefan Binding <sbinding@...nsource.cirrus.com>,
	Simon Trimmer <simont@...nsource.cirrus.com>,
	Joshua Grisham <josh@...huagrisham.com>,
	alexander.scholten@...dite-tech.com,
	dwayne.dupreez@...dite-tech.com,
	zenon@...dite-tech.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Limit Internal Microphone boost for ALC3246

On Sun, 09 Mar 2025 13:39:36 +0100,
Chester A. Unal via B4 Relay wrote:
> 
> From: "Chester A. Unal" <chester.a.unal@...nc9.com>
> 
> Internal Microphone is too loud on Dell Latitude 5490, Dell Device
> [1028:0816], which has got ALC3246. I suppose this is the case for all
> devices with ALC3246 which is ALC256 for Dell devices. Therefore, limit the
> Internal Microphone boost for ALC3246. Change
> ALC255_FIXUP_DELL1_MIC_NO_PRESENCE to
> ALC255_FIXUP_DELL1_LIMIT_INT_MIC_BOOST which includes the former fixup.
> 
> Signed-off-by: Chester A. Unal <chester.a.unal@...nc9.com>

Thanks for the patch.

The code replaces the quirk entry for a pin-quirk table, and it
implies that this change will influence on all models that have this
pin table pattern, which is a bit risky to change.
IMO, a safer option would be to add an explicit PCI SSID quirk entry
for your device pointing to ALC255_FIXUP_DELL1_LIMIT_INT_MIC_BOOST.

> ---
> I don't know ALSA or the Intel HDA specification very well so feel free to
> correct any incorrect information in the patch log.
> 
> I experience another issue with this laptop that is also there on ALC3204.
> Headphones output loops back to Headset Microphone. So if I record with
> this microphone, sysystem audio is recorded as well. I have tried a fair
> share of fixups by compiling snd-hda-codec-realtek.ko with different fixups
> applied for "0x10ec0256, 0x1028", replacing the existing module in
> /lib/modules, and then rebooting.

The "headphone" mic means to use the pin used for the headphone output
as the mic input.  If turned on, the pin usage is switched from the
output to the input, hence no playback from there any longer.
And, a headphone can be indeed used physically as a mic (although the
tone is very soft) -- so it's the expected behavior.

OTOH, "headset" mic is different; it has both the headset output pin
and the headset mic pin that work individually.

> ALC2XX_FIXUP_HEADSET_MIC makes Headset Microphone appear unplugged. But I
> can see on the OS that it detects voice, so, it works. When it appears
> unplugged, Headphones output won't loop back to it. This fixup also makes
> Speakers appear unavailable and makes Microphone disappear, as
> ALC255_FIXUP_DELL1_MIC_NO_PRESENCE won't apply anymore.

If the headset isn't detected by plugging to the headset jack, that's
a bug to be fixed.  Please elaborate the behavior.


thanks,

Takashi