linux-kernel - Re: [PATCH] [v2] x86: coco: replace static const cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qlgpflicsfcwtr3jpya26arz25jhqjq6254madvjx4yl7diibx@4yyyzscorxxr>
Date: Tue, 11 Mar 2025 12:55:38 +0200
From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, 
	Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
	Tom Lendacky <thomas.lendacky@....com>, Rick Edgecombe <rick.p.edgecombe@...el.com>, 
	Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>, Arnd Bergmann <arnd@...db.de>, "H. Peter Anvin" <hpa@...or.com>, 
	Elena Reshetova <elena.reshetova@...el.com>, "Jason A. Donenfeld" <Jason@...c4.com>, 
	Yue Haibing <yuehaibing@...wei.com>, Juergen Gross <jgross@...e.com>, 
	David Woodhouse <dwmw@...zon.co.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] x86: coco: replace static const cc_mask with a
 function

On Mon, Mar 10, 2025 at 02:10:59PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When extra warnings are enabled, the cc_mask definition in asm/coco.h
> causes a build failure with gcc:
> 
> arch/x86/include/asm/coco.h:28:18: error: 'cc_mask' defined but not used [-Werror=unused-const-variable=]
>    28 | static const u64 cc_mask = 0;
> 
> Add a cc_get_mask() function mirroring cc_set_mask() for the one
> user of the variable outside of the coco implementation.
> 
> Fixes: a0a8d15a798b ("x86/tdx: Preserve shared bit on mprotect()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> --
> v2: use an inline helper instead of a __maybe_unused annotaiton.

Reviewed-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov