linux-kernel - Re: [PATCH v2] staging: comedi: remove redundant filename references in headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025031113-resize-charbroil-0d6d@gregkh>
Date: Tue, 11 Mar 2025 12:17:17 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Siddarth G <siddarthsgml@...il.com>
Cc: abbotti@....co.uk, hsweeten@...ionengravers.com,
	skhan@...uxfoundation.org, linux-kernel@...r.kernel.org,
	ruffalolavoisier@...il.com, colin.i.king@...il.com,
	n.zhandarovich@...tech.ru
Subject: Re: [PATCH v2] staging: comedi: remove redundant filename references
 in headers

On Tue, Mar 11, 2025 at 03:37:41PM +0530, Siddarth G wrote:
> checkpatch.pl reports the following warning in COMEDI subsystem files:
>   WARNING: It's generally not useful to have the filename in the file
> These file headers contain redundant filename references (e.g., "* comedi_buf.c"
> in comedi_buf.c) which are unnecessary.
> This patch removes these references from 14 files to comply with kernel coding
> standards and eliminate the warnings.
> 
> Signed-off-by: Siddarth G <siddarthsgml@...il.com>
> ---
> Changes in v2:
> -Included the exact checkpatch.pl warning in the commit message for clarity.
> ---
>  drivers/comedi/comedi_buf.c                          | 1 -
>  drivers/comedi/comedi_fops.c                         | 1 -
>  drivers/comedi/comedi_pci.c                          | 1 -
>  drivers/comedi/comedi_pcmcia.c                       | 1 -
>  drivers/comedi/comedi_usb.c                          | 1 -
>  drivers/comedi/drivers.c                             | 1 -
>  drivers/comedi/drivers/ni_routing/ni_device_routes.c | 1 -
>  drivers/comedi/drivers/ni_routing/ni_device_routes.h | 1 -
>  drivers/comedi/drivers/ni_routing/ni_route_values.c  | 1 -
>  drivers/comedi/drivers/ni_routing/ni_route_values.h  | 1 -
>  drivers/comedi/drivers/tests/comedi_example_test.c   | 1 -
>  drivers/comedi/drivers/tests/ni_routes_test.c        | 1 -
>  drivers/comedi/drivers/tests/unittest.h              | 1 -
>  drivers/comedi/range.c                               | 1 -

These files are not in the "staging" directory, so no need for staging/
to be in the subject line at all :(

Also, start by working on checkpatch cleanups in the drivers/staging/
directory, not elsewhere in the kernel tree, so you get experience in
doing all of this properly before moving out to other areas.  Also, some
subsystems do not want checkpatch cleanups, so be careful.

thanks,

greg k-h