linux-kernel - Re: [PATCH v7 bpf-next 2/2] selftests/bpf: Add a kernel flag test for LSM bpf hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQK9UiOoNxR6TE6Oc2SnEJ2i5Jt6pmvrviZ6OrNJhbyV+g@mail.gmail.com>
Date: Tue, 11 Mar 2025 12:30:51 +0100
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Song Liu <song@...nel.org>
Cc: Blaise Boscaccy <bboscaccy@...ux.microsoft.com>, Paul Moore <paul@...l-moore.com>, 
	James Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, 
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	John Fastabend <john.fastabend@...il.com>, Andrii Nakryiko <andrii@...nel.org>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>, 
	Yonghong Song <yonghong.song@...ux.dev>, KP Singh <kpsingh@...nel.org>, 
	Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, 
	Stephen Smalley <stephen.smalley.work@...il.com>, Ondrej Mosnacek <omosnace@...hat.com>, 
	Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>, 
	Kumar Kartikeya Dwivedi <memxor@...il.com>, Matt Bobrowski <mattbobrowski@...gle.com>, 
	Xu Kuohai <xukuohai@...wei.com>, LKML <linux-kernel@...r.kernel.org>, 
	LSM List <linux-security-module@...r.kernel.org>, bpf <bpf@...r.kernel.org>, 
	selinux@...r.kernel.org, 
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v7 bpf-next 2/2] selftests/bpf: Add a kernel flag test for
 LSM bpf hook

On Tue, Mar 11, 2025 at 12:07 AM Song Liu <song@...nel.org> wrote:
> > +       lskel = kfunc_call_test_lskel__open_and_load();
> > +       if (!ASSERT_ERR_PTR(lskel, "lskel"))
> > +               goto close_prog;
>
> This goto is not necessary. But I don't think we need v8 just for this.

I left goto as-is while applying.
I felt all error handling being consistent this way is cleaner.