linux-kernel - RE: [RFC PATCH 1/3] thermal/cpuplog_cooling: Add CPU hotplug cooling driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OSBPR01MB27750EEBDC394321FEB84B1EFFD12@OSBPR01MB2775.jpnprd01.prod.outlook.com>
Date: Tue, 11 Mar 2025 11:41:15 +0000
From: John Madieu <john.madieu.xa@...renesas.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
CC: "niklas.soderlund+renesas@...natech.se"
	<niklas.soderlund+renesas@...natech.se>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "rafael@...nel.org" <rafael@...nel.org>,
	"daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
	"magnus.damm@...il.com" <magnus.damm@...il.com>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "john.madieu@...il.com"
	<john.madieu@...il.com>, "rui.zhang@...el.com" <rui.zhang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, Biju
 Das <biju.das.jz@...renesas.com>, "linux-pm@...r.kernel.org"
	<linux-pm@...r.kernel.org>
Subject: RE: [RFC PATCH 1/3] thermal/cpuplog_cooling: Add CPU hotplug cooling
 driver

Hi Geert,

Thanks for your review.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: Tuesday, March 11, 2025 9:28 AM
> To: John Madieu <john.madieu.xa@...renesas.com>
> Subject: Re: [RFC PATCH 1/3] thermal/cpuplog_cooling: Add CPU hotplug
> cooling driver
> 
> Hi John,
> 
> On Sun, 9 Mar 2025 at 13:14, John Madieu <john.madieu.xa@...renesas.com>
> wrote:
> > Add thermal cooling mechanism that dynamically manages CPU
> > online/offline states to prevent overheating. It registers  per-CPU
> > cooling devices that can take CPUs offline when thermal thresholds are
> > excee and that integrates with the Linux thermal framework as a cooling
> devices.
> >
> > Signed-off-by: John Madieu <john.madieu.xa@...renesas.com>
> 
> Thanks for your patch!
> 
> > --- /dev/null
> > +++ b/drivers/thermal/cpuplug_cooling.c
> 
> > +static int register_cpu_hotplug_cooling(struct device_node *cpu_node,
> > +                                       int cpu_id) {
> 
> > +       hotplug_cdev = kzalloc(sizeof(*hotplug_cdev), GFP_KERNEL);
> > +       if (!hotplug_cdev) {
> > +               pr_err("Failed to allocate memory for cooling
> > + device\n");
> 
> scripts/checkpatch.pl:
> 
> WARNING: Possible unnecessary 'out of memory' message
> 
> and checkpatch is right, as the memory core already takes care of printing
> a message.
> 

Will be removed in v2.

> > +               return -ENOMEM;
> > +       }
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --

Regards,
John