linux-kernel - Re: linux-next: build failure after merge of the watchdog tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3da76007-31f0-404a-a324-dd3068e339c5@app.fastmail.com>
Date: Tue, 11 Mar 2025 08:12:41 -0400
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: "Stephen Rothwell" <sfr@...b.auug.org.au>,
 "Wim Van Sebroeck" <wim@...ana.be>
Cc: "Guenter Roeck" <linux@...ck-us.net>,
 "Wim Van Sebroeck" <wim@...ux-watchdog.org>,
 "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
 "Linux Next Mailing List" <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the watchdog tree

Thanks Stephen,

On Tue, Mar 11, 2025, at 6:03 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the watchdog tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/watchdog/lenovo_se30_wdt.c: In function 'lenovo_se30_wdt_probe':
> drivers/watchdog/lenovo_se30_wdt.c:272:31: error: implicit declaration 
> of function 'devm_ioremap' [-Wimplicit-function-declaration]
>   272 |         priv->shm_base_addr = devm_ioremap(dev, base_phys, 
> SHM_WIN_SIZE);
>       |                               ^~~~~~~~~~~~
> drivers/watchdog/lenovo_se30_wdt.c:272:29: error: assignment to 
> 'unsigned char *' from 'int' makes pointer from integer without a cast 
> [-Wint-conversion]
>   272 |         priv->shm_base_addr = devm_ioremap(dev, base_phys, 
> SHM_WIN_SIZE);
>       |                             ^
>
> Caused by commit
>
>   c284153a2c55 ("watchdog: lenovo_se30_wdt: Watchdog driver for Lenovo 
> SE30 platform")
>
> Somewhere alogn the way a change to some include file means that
> linux/io.h is no longer implicitly included.  I have added the following
> patch for today.
>
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Tue, 11 Mar 2025 20:50:05 +1100
> Subject: [PATCH] watchdog: lenovo_se30_wdt: include io.h for devm_ioremap()
>
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
>  drivers/watchdog/lenovo_se30_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/lenovo_se30_wdt.c 
> b/drivers/watchdog/lenovo_se30_wdt.c
> index f25429da0cec..024b842499b3 100644
> --- a/drivers/watchdog/lenovo_se30_wdt.c
> +++ b/drivers/watchdog/lenovo_se30_wdt.c
> @@ -5,6 +5,7 @@
> 
>  #define dev_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> +#include <linux/io.h>
>  #include <linux/dmi.h>
>  #include <linux/delay.h>
>  #include <linux/iommu.h>
> -- 
> 2.45.2
>
> -- 
Appreciate you getting this done so fast - it was on my todo list for today.
Apologies for the build break.

Change looks good to me.
Reviewed-by: Mark Pearson <mpearson-lenovo@...ebb.ca>

Mark