linux-kernel - Re: [PATCH mm-unstable 0/2] mseal system mappings fix + s390 enablement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a326735d-ca3e-4aee-9f98-4e742dfc15f5@lucifer.local>
Date: Tue, 11 Mar 2025 13:02:47 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Jeff Xu <jeffxu@...omium.org>,
        "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Kees Cook <kees@...nel.org>,
        Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH mm-unstable 0/2] mseal system mappings fix + s390
 enablement

On Tue, Mar 11, 2025 at 01:33:24PM +0100, Heiko Carstens wrote:
> When rebasing the mseal series on top of the generic vdso data storage
> the VM_SEALED_SYSMAP vm flag for the vvar mapping got lost. Add that again.

I'm confused by this? Some merge patch resolution thing?

I don't think this should be at the top of a description of a series, seems more
like an addendum.

>
> Also add s390 support for MSEAL_SYSTEM_MAPPINGS.

'Also' = the whole thing this series does?

Can you confirm that s390 absolutely does not rely upon
moving/manipulating/etc. the VDSO, VVAR, etc. mappings?

You should say that here.

>
> Heiko Carstens (2):
>   mseal sysmap: generic vdso vvar mapping
>   mseal sysmap: enable s390
>
>  arch/s390/Kconfig       | 1 +
>  arch/s390/kernel/vdso.c | 2 +-
>  lib/vdso/datastore.c    | 3 ++-
>  3 files changed, 4 insertions(+), 2 deletions(-)
>
> --
> 2.45.2
>