linux-kernel - Re: [PATCH v7 03/11] dt-bindings: pci: Add common schema for devices accessible through PCI BARs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKPGOdS_8KDggO5tBHAnC-NTLAC5iS9GANm9BuxBfQUsw@mail.gmail.com>
Date: Tue, 11 Mar 2025 08:32:28 -0500
From: Rob Herring <robh@...nel.org>
To: Krzysztof Wilczynski <kw@...ux.com>
Cc: Andrea della Porta <andrea.porta@...e.com>, Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Catalin Marinas <catalin.marinas@....com>, 
	Will Deacon <will@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>, Derek Kiernan <derek.kiernan@....com>, 
	Dragan Cvetic <dragan.cvetic@....com>, Arnd Bergmann <arnd@...db.de>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Saravana Kannan <saravanak@...gle.com>, 
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, 
	linux-gpio@...r.kernel.org, Masahiro Yamada <masahiroy@...nel.org>, 
	Stefan Wahren <wahrenst@....net>, Herve Codina <herve.codina@...tlin.com>, 
	Luca Ceresoli <luca.ceresoli@...tlin.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v7 03/11] dt-bindings: pci: Add common schema for devices
 accessible through PCI BARs

On Mon, Mar 10, 2025 at 4:21 PM Krzysztof Wilczynski <kw@...ux.com> wrote:
>
> Hello,
>
> [...]
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index d45c88955072..af2e4652bf3b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -19752,6 +19752,7 @@ RASPBERRY PI RP1 PCI DRIVER
> >  M:   Andrea della Porta <andrea.porta@...e.com>
> >  S:   Maintained
> >  F:   Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml
> > +F:   Documentation/devicetree/bindings/pci/pci-ep-bus.yaml
> >  F:   Documentation/devicetree/bindings/pinctrl/raspberrypi,rp1-gpio.yaml
> >  F:   include/dt-bindings/clock/rp1.h
> >  F:   include/dt-bindings/misc/rp1.h
>
> I would be happy to pick this via the PCI tree as per the standard
> operating procedure.  However, the MAINTAINERS changes do not exist
> for us yet, and are added in the first patch of the series, which is
> not ideal.
>
> I can add the missing dependency manually, but that would cause issues
> for linux-next tree, which is also not ideal.
>
> I saw some review feedback, as such, when you are going to be sending
> another version, can you make MAINTAINERS changes to be the last patch,
> perhaps.  Basically, something standalone that perhaps whoever will pick
> the misc patch could also pick and apply at the same time.
>
> Alternatively, someone else picking up the PCI dt-bindings would work, too.
>
> Your thoughts?

I guess I missed this in review, but why is a common schema buried in
a device maintainer entry? Also, an entry in MAINTAINERS is redundant
anyway because get_maintainers.pl can fetch maintainers from the
schema file.

Rob