linux-kernel - Re: [PATCH v3 3/5] ASoC: dt-bindings: wm8904: Add DMIC, GPIO, MIC and EQ support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0898b492-71ed-4df3-bf81-c3965e4c7ec7@sirena.org.uk>
Date: Tue, 11 Mar 2025 13:46:58 +0000
From: Mark Brown <broonie@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Francesco Dolcini <francesco@...cini.it>,
	Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Saravana Kannan <saravanak@...gle.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	patches@...nsource.cirrus.com,
	Ernest Van Hoecke <ernest.vanhoecke@...adex.com>,
	linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Francesco Dolcini <francesco.dolcini@...adex.com>,
	Charles Keepax <ckeepax@...nsource.cirrus.com>
Subject: Re: [PATCH v3 3/5] ASoC: dt-bindings: wm8904: Add DMIC, GPIO, MIC
 and EQ support

On Tue, Mar 11, 2025 at 09:42:45AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Mar 07, 2025 at 02:52:42PM +0100, Francesco Dolcini wrote:

> > +  wlf,in1l-as-dmicdat1:
> > +    type: boolean
> > +    description:
> > +      Use IN1L/DMICDAT1 as DMICDAT1, enabling the DMIC input path.

> > +  wlf,in1r-as-dmicdat2:
> > +    type: boolean
> > +    description:
> > +      Use IN1R/DMICDAT2 as DMICDAT2, enabling the DMIC input path.

> Are these two properties mutually exclusive?

No, it's one property each for the left and right channels.

> > +  wlf,drc-cfg-names:
> > +    $ref: /schemas/types.yaml#/definitions/string-array

> No constraints, so I assume you can have here any number of items?

Yes.

> > +    description:
> > +      List of strings for the available DRC modes.

> Why the actual names are not defined? Why do you need this property if
> they are not defined (thus driver does not request this by the name)?

The driver displays the list of names to the end user for them to choose
between.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)