linux-kernel - Re: [PATCH] igc: enable HW VLAN insertion/stripping by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250311135236.GO4159220@kernel.org>
Date: Tue, 11 Mar 2025 14:52:36 +0100
From: Simon Horman <horms@...nel.org>
To: Rui Salvaterra <rsalvaterra@...il.com>
Cc: muhammad.husaini.zulkifli@...el.com, anthony.l.nguyen@...el.com,
	przemyslaw.kitszel@...el.com, edumazet@...gle.com, kuba@...nel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] igc: enable HW VLAN insertion/stripping by default

On Fri, Mar 07, 2025 at 11:02:39AM +0000, Rui Salvaterra wrote:
> This is enabled by default in other Intel drivers I've checked (e1000, e1000e,
> iavf, igb and ice). Fixes an out-of-the-box performance issue when running
> OpenWrt on typical mini-PCs with igc-supported Ethernet controllers and 802.1Q
> VLAN configurations, as ethtool isn't part of the default packages and sane
> defaults are expected.
> 
> In my specific case, with an Intel N100-based machine with four I226-V Ethernet
> controllers, my upload performance increased from under 30 Mb/s to the expected
> ~1 Gb/s.
> 
> Signed-off-by: Rui Salvaterra <rsalvaterra@...il.com>
> ---
> 
> This patch cost me two afternoons of network debugging, last weekend. Is there
> any plausible reason why VLAN acceleration wasn't enabled by default for this
> driver, specifically?

Having looked over this I am also curious to know the answer to that question.
This does seem to be the default for other Intel drivers (at least).