linux-kernel - Re: [PATCH v1 1/1] kbuild: Add "make headers" to "make help" output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08bbfff0-4aef-4d9e-bbeb-661aedaf3737@zytor.com>
Date: Mon, 10 Mar 2025 19:19:05 -0700
From: Xin Li <xin@...or.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        nathan@...nel.org, nicolas@...sle.eu, bp@...en8.de, hpa@...or.com,
        sraithal@....com
Subject: Re: [PATCH v1 1/1] kbuild: Add "make headers" to "make help" output

On 3/10/2025 6:52 PM, Masahiro Yamada wrote:
> On Mon, Mar 10, 2025 at 3:23 PM Xin Li <xin@...or.com> wrote:
>>
>> On 3/8/2025 7:12 AM, Masahiro Yamada wrote:
>>> On Sat, Mar 8, 2025 at 1:05 PM Xin Li (Intel) <xin@...or.com> wrote:
>>>>
>>>> Meanwhile explicitly state that the headers are uapi headers.
>>>
>>> There are many internal-use targets, which are not documented in the
>>> help message.
>>> I assume this one is the case.
>>>
>>> If users want to install UAPI headers, 'headers_install' is
>>> the user-visible interface and it is already documented.
>>>
>>>
>>
>> hpa and Boris prefer to add it, which I also agree.  But ofc it's your
>> call :)
>>
>> If you don't want to add help for "headers", it probably still makes
>> sense to explicitly state that the headers are uapi headers, no?
>>
>> Thanks!
>>       Xin
> 
> 
> If a help message for "headers" is desired, how about this?
> 
>    headers  - Build read-to-install uapi headers in usr/include
> 

LGTM.

I guess you will make the change right now?

Thanks!
     Xin