linux-kernel - Re: [PATCH] rtc: renesas-rtca3: Disable interrupts only if the RTC is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174170229131.122687.7673769665221505854.b4-ty@bootlin.com>
Date: Tue, 11 Mar 2025 15:11:42 +0100
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Claudiu <claudiu.beznea@...on.dev>
Cc: linux-rtc@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH] rtc: renesas-rtca3: Disable interrupts only if the RTC
 is enabled

On Wed, 05 Feb 2025 11:55:19 +0200, Claudiu wrote:
> If the RTC is not enabled and the code attempts to disable the interrupt,
> the readb_poll_timeout_atomic() function in the
> rtca3_alarm_irq_set_helper() may timeout, leading to probe failures.
> This issue is reproducible on some devices because the initial values of
> the PIE and AIE bits in the RCR1 register are undefined.
> 
> To prevent probe failures in this scenario, disable RTC interrupts only
> when the RTC is actually enabled.
> 
> [...]

Applied, thanks!

[1/1] rtc: renesas-rtca3: Disable interrupts only if the RTC is enabled
      https://git.kernel.org/abelloni/c/27b2fcbd6b98

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com