linux-kernel - Re: [PATCH v4 7/7] thermal: core: Record PSCR before hw_protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9G7g5fr8DkJtcLI@pengutronix.de>
Date: Wed, 12 Mar 2025 17:51:15 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: Sebastian Reichel <sre@...nel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
	linux-pm@...r.kernel.org,
	Søren Andersen <san@...v.dk>
Subject: Re: [PATCH v4 7/7] thermal: core: Record PSCR before
 hw_protection_shutdown()

Hi Daniel,

On Wed, Mar 12, 2025 at 04:35:51PM +0100, Daniel Lezcano wrote:
> > @@ -380,6 +381,8 @@ static void thermal_zone_device_halt(struct thermal_zone_device *tz, bool shutdo
> >   	dev_emerg(&tz->device, "%s: critical temperature reached\n", tz->type);
> > +	set_power_state_change_reason(PSCR_OVERTEMPERATURE);
> > +
> >   	if (shutdown)
> >   		hw_protection_shutdown(msg, poweroff_delay_ms);
> >   	else
> 
> In the future could you add me as recipient to the series instead of this
> one ? so I can get more context.

ack.

> Given there are no so much hw_protection_shutdown() users in the kernel, it
> could be more interesting to change the function to receive a enum
> pscr_reason and then in the hw_protection_shutdown() call
> pscrr_reason_to_str().
 
Do you mean, make it work with CONFIG_PSCRR=n?

Beside, the latest version is v5:
https://lore.kernel.org/all/20250310103732.423542-1-o.rempel@pengutronix.de/

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |