linux-kernel - Re: [PATCH] PNP: Expand length of fixup id string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hxrj-DW7a=3iXmsCFm-K4rJvsrG=f5YLJreVmaZ207Lw@mail.gmail.com>
Date: Wed, 12 Mar 2025 20:42:15 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Kees Cook <kees@...nel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] PNP: Expand length of fixup id string

On Mon, Mar 10, 2025 at 11:24 PM Kees Cook <kees@...nel.org> wrote:
>
> GCC 15's -Wunterminated-string-initialization saw that "id" was not
> including the required trailing NUL character. Instead of marking "id"
> with __nonstring[1], expand the length of the string as it is used in
> (debugging) format strings that expect a properly formed C string.
>
> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117178 [1]
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
> Cc: linux-acpi@...r.kernel.org
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
>  include/linux/pnp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> index b7a7158aaf65..23fe3eaf242d 100644
> --- a/include/linux/pnp.h
> +++ b/include/linux/pnp.h
> @@ -290,7 +290,7 @@ static inline void pnp_set_drvdata(struct pnp_dev *pdev, void *data)
>  }
>
>  struct pnp_fixup {
> -       char id[7];
> +       char id[8];
>         void (*quirk_function) (struct pnp_dev *dev);   /* fixup function */
>  };
>
> --

Applied as 6.15 material, thanks!