linux-kernel - Re: wifi: iwlwifi: Fix uninitialized variable with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ea83bd5-b19b-4bd8-ac2a-8fb2ad616f8b@web.de>
Date: Wed, 12 Mar 2025 21:16:42 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Miriam Rachel Korenblit <miriam.rachel.korenblit@...el.com>,
 Dan Carpenter <dan.carpenter@...aro.org>, linux-wireless@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Anjaneyulu <pagadala.yesu.anjaneyulu@...el.com>,
 Avraham Stern <avraham.stern@...el.com>,
 Daniel Gabay <daniel.gabay@...el.com>,
 Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
 Jeff Johnson <jeff.johnson@....qualcomm.com>,
 Johannes Berg <johannes.berg@...el.com>,
 Yedidya Benshimol <yedidya.ben.shimol@...el.com>
Subject: Re: wifi: iwlwifi: Fix uninitialized variable with __free()

>> Can it be recommended to reduce the scope for the affected local variable instead?
>> https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/cleanup.h#L129-L133
>
> As said in reply to Jeff's review -
> This is recommended if you have multiple __kfree variables (and the order of freeing matters)
> Or if there is a guard() later in the function.
How does such a view fit to the documentation of this programming interface?

Regards,
Markus