linux-kernel - Re: [PATCH] wifi: carl9170: Add __nonstring annotations for unterminated strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3793ce70-efed-4c86-8c34-7fe22f8e4b0f@gmail.com>
Date: Wed, 12 Mar 2025 21:45:49 +0100
From: Christian Lamparter <chunkeey@...il.com>
To: Kees Cook <kees@...nel.org>, Christian Lamparter <chunkeey@...glemail.com>
Cc: Johannes Berg <johannes@...solutions.net>,
 linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH] wifi: carl9170: Add __nonstring annotations for
 unterminated strings

On 3/10/25 11:23 PM, Kees Cook wrote:
> When a character array without a terminating NUL character has a static
> initializer, GCC 15's -Wunterminated-string-initialization will only
> warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
> with __nonstring to and correctly identify the char array as "not a C
> string" and thereby eliminate the warning.

Sure. Thank you!

> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117178 [1]
> Cc: Christian Lamparter <chunkeey@...glemail.com>
> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: linux-wireless@...r.kernel.org
> Signed-off-by: Kees Cook <kees@...nel.org>
Acked-by: Christian Lamparter <chunkeey@...il.com>
> ---
>   drivers/net/wireless/ath/carl9170/fw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/carl9170/fw.c b/drivers/net/wireless/ath/carl9170/fw.c
> index 4c1aecd1163c..419f5530f885 100644
> --- a/drivers/net/wireless/ath/carl9170/fw.c
> +++ b/drivers/net/wireless/ath/carl9170/fw.c
> @@ -15,7 +15,7 @@
>   #include "fwcmd.h"
>   #include "version.h"
>   
> -static const u8 otus_magic[4] = { OTUS_MAGIC };
> +static const u8 otus_magic[4] __nonstring = { OTUS_MAGIC };
>   
>   static const void *carl9170_fw_find_desc(struct ar9170 *ar, const u8 descid[4],
>   	const unsigned int len, const u8 compatible_revision)