linux-kernel - Re: [PATCH] igc: enable HW VLAN insertion/stripping by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe021b67-94f6-43e4-9130-7b9a58919b40@intel.com>
Date: Wed, 12 Mar 2025 14:43:33 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Rui Salvaterra <rsalvaterra@...il.com>, Simon Horman <horms@...nel.org>
CC: <muhammad.husaini.zulkifli@...el.com>, <przemyslaw.kitszel@...el.com>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] igc: enable HW VLAN insertion/stripping by default

On 3/11/2025 6:59 AM, Rui Salvaterra wrote:
> Hi, Simon,
> 
> On Tue, 11 Mar 2025 at 13:52, Simon Horman <horms@...nel.org> wrote:
>>
>> Having looked over this I am also curious to know the answer to that question.
>> This does seem to be the default for other Intel drivers (at least).

Unfortunately, I'm unable check with the original author or those 
involved at the time. From asking around it sounds like there may have 
been some initial issues when implementing this; my theory is this was 
off by default so that it would minimize the affects if additional 
issues were discovered.

I see that you missed Intel Wired LAN (intel-wired-lan@...ts.osuosl.org) 
on the patch. Could you resend with the list included? Also, if you 
could make it 'PATCH iwl-next' to target the Intel -next tree as that 
seems the appropriate tree.

Thanks,
Tony

> Well, r8169 also enables it, and RealTek controllers are used everywhere. :)
> 
> Kind regards,
> Rui Salvaterra