linux-kernel - Re: [PATCH v1 1/2] spi: sg2044-nor: Fully convert to device managed resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202503130708.AmtUDVfq-lkp@intel.com>
Date: Thu, 13 Mar 2025 07:34:50 +0800
From: kernel test robot <lkp@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Longbin Li <looong.bin@...il.com>, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v1 1/2] spi: sg2044-nor: Fully convert to device managed
 resources

Hi Andy,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-spi/for-next]
[cannot apply to linus/master v6.14-rc6 next-20250312]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/spi-sg2044-nor-Fully-convert-to-device-managed-resources/20250313-012347
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20250312172016.4070094-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/2] spi: sg2044-nor: Fully convert to device managed resources
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20250313/202503130708.AmtUDVfq-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250313/202503130708.AmtUDVfq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503130708.AmtUDVfq-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/spi/spi-sg2044-nor.c: In function 'sg2044_spifmc_probe':
>> drivers/spi/spi-sg2044-nor.c:459:44: error: macro "devm_mutex_init" requires 2 arguments, but only 1 given
     459 |         ret = devm_mutex_init(&spifmc->lock);
         |                                            ^
   In file included from include/linux/notifier.h:14,
                    from include/linux/clk.h:14,
                    from drivers/spi/spi-sg2044-nor.c:9:
   include/linux/mutex.h:144:9: note: macro "devm_mutex_init" defined here
     144 | #define devm_mutex_init(dev, mutex)                     \
         |         ^~~~~~~~~~~~~~~
>> drivers/spi/spi-sg2044-nor.c:459:15: error: 'devm_mutex_init' undeclared (first use in this function)
     459 |         ret = devm_mutex_init(&spifmc->lock);
         |               ^~~~~~~~~~~~~~~
   drivers/spi/spi-sg2044-nor.c:459:15: note: each undeclared identifier is reported only once for each function it appears in


vim +/devm_mutex_init +459 drivers/spi/spi-sg2044-nor.c

   425	
   426	static int sg2044_spifmc_probe(struct platform_device *pdev)
   427	{
   428		struct spi_controller *ctrl;
   429		struct sg2044_spifmc *spifmc;
   430		void __iomem *base;
   431		int ret;
   432	
   433		ctrl = devm_spi_alloc_host(&pdev->dev, sizeof(*spifmc));
   434		if (!ctrl)
   435			return -ENOMEM;
   436	
   437		spifmc = spi_controller_get_devdata(ctrl);
   438	
   439		spifmc->clk = devm_clk_get_enabled(&pdev->dev, NULL);
   440		if (IS_ERR(spifmc->clk))
   441			return dev_err_probe(&pdev->dev, PTR_ERR(spifmc->clk),
   442					     "%s: Cannot get and enable AHB clock\n",
   443					     __func__);
   444	
   445		spifmc->dev = &pdev->dev;
   446		spifmc->ctrl = ctrl;
   447	
   448		spifmc->io_base = devm_platform_ioremap_resource(pdev, 0);
   449		if (IS_ERR(base))
   450			return PTR_ERR(base);
   451	
   452		ctrl->num_chipselect = 1;
   453		ctrl->dev.of_node = pdev->dev.of_node;
   454		ctrl->bits_per_word_mask = SPI_BPW_MASK(8);
   455		ctrl->auto_runtime_pm = false;
   456		ctrl->mem_ops = &sg2044_spifmc_mem_ops;
   457		ctrl->mode_bits = SPI_RX_DUAL | SPI_TX_DUAL | SPI_RX_QUAD | SPI_TX_QUAD;
   458	
 > 459		ret = devm_mutex_init(&spifmc->lock);
   460		if (ret)
   461			return ret;
   462	
   463		sg2044_spifmc_init(spifmc);
   464		sg2044_spifmc_init_reg(spifmc);
   465	
   466		ret = devm_spi_register_controller(&pdev->dev, ctrl);
   467		if (ret) {
   468			dev_err(&pdev->dev, "spi_register_controller failed\n");
   469			return ret;
   470		}
   471	
   472		return 0;
   473	}
   474	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki