linux-kernel - Re: [PATCH RFC v2 1/2] platform/x86: wmi: Add wmidev_get_acpi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D8E1ENUHLP10.2BBUD2EP7MRGZ@gmail.com>
Date: Wed, 12 Mar 2025 00:27:06 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: "Armin Wolf" <W_Armin@....de>, "Hans de Goede" <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: <platform-driver-x86@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <Dell.Client.Kernel@...l.com>
Subject: Re: [PATCH RFC v2 1/2] platform/x86: wmi: Add
 wmidev_get_acpi_device_uid()

On Tue Mar 11, 2025 at 2:21 PM -05, Armin Wolf wrote:
> Am 09.03.25 um 06:13 schrieb Kurt Borja:
>
>> Add a non-deprecated version of wmi_get_acpi_device_uid().
>
> Hi,
>
> i can understand you motivation behind this patch, but this is IMHO the wrong approach.
> Nothing guarantees us that a given ACPI _UID value will reliably signal the presence of
> WMI methods now or in the future. Because of this i am against this patch.

Yes, in the end it is a leap of faith.

I think that it's not very risky as AFAIK AWCC didn't even exist when
devices used the legacy RGB interface. Also as Mario mentioned, only a
handful of devices supported the legacy interface, compared to the large
amount of systems with the AWCC one.

But of course, there is always a possibility of regressions for some
unknown edge case.

>
> The correct way would be to use the BMOF data to check for missing WMI methods. I did
> some work on that which i will announce soon.

Anyways, this is very cool and indeed the correct approach. Hopefully
I'll be able to help a bit, as I spent some time studying Pali's
decoder.

-- 
 ~ Kurt