linux-kernel - Re: [patch V3a 17/18] posix-timers: Provide a mechanism to allocate a given timer ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9E-L1pvl1j_4E3f@grain>
Date: Wed, 12 Mar 2025 10:56:31 +0300
From: Cyrill Gorcunov <gorcunov@...il.com>
To: Frederic Weisbecker <frederic@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Benjamin Segall <bsegall@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Andrey Vagin <avagin@...nvz.org>,
	Pavel Tikhomirov <ptikhomirov@...tuozzo.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [patch V3a 17/18] posix-timers: Provide a mechanism to allocate
 a given timer ID

On Tue, Mar 11, 2025 at 11:32:58PM +0100, Frederic Weisbecker wrote:
...
> > 
> > Recreating two timers with IDs 1000000 and 2000000 takes 1.5 seconds with
> > the create/delete method. With the prctl() it takes 3 microseconds.
> > 
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> 
> Reviewed-by: Frederic Weisbecker <frederic@...nel.org>

One thing which just popped up in my head -- this interface may be used not
only by criu but any application which wants to create timer with specified
id (hell know why, but whatever). As far as I understand we don't provide
an interface to _read_ this property, don't we? Thus criu will restore such
application which already has this bit set incorrectly.

	Cyrill