linux-kernel - [PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33F3F7E2-24AE-4F29-9053-3B502D075BA8@live.com>
Date: Wed, 12 Mar 2025 09:06:42 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Thomas Zimmermann <tzimmermann@...e.de>, Aun-Ali Zaidi <admin@...eit.net>,
	Maxime Ripard <mripard@...nel.org>, "airlied@...hat.com"
	<airlied@...hat.com>, Simona Vetter <simona@...ll.ch>,
	"andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>, Petr
 Mladek <pmladek@...e.com>, Steven Rostedt <rostedt@...dmis.org>, Rasmus
 Villemoes <linux@...musvillemoes.dk>, "senozhatsky@...omium.org"
	<senozhatsky@...omium.org>, Jonathan Corbet <corbet@....net>, Andrew Morton
	<akpm@...ux-foundation.org>, "apw@...onical.com" <apw@...onical.com>,
	"joe@...ches.com" <joe@...ches.com>, "dwaipayanray1@...il.com"
	<dwaipayanray1@...il.com>, "lukas.bulwahn@...il.com"
	<lukas.bulwahn@...il.com>
CC: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, Hector Martin
	<marcan@...can.st>, Sven Peter <sven@...npeter.dev>, Asahi Linux Mailing List
	<asahi@...ts.linux.dev>
Subject: [PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc

From: Aditya Garg <gargaditya08@...e.com>

Due to lack of a proper printk format, %p4cc was being used instead of
%p4cl for the purpose of printing FourCCs. But the disadvange was that
they were being printed in a reverse order. %p4cl should correct this
issue.

Signed-off-by: Aditya Garg <gargaditya08@...e.com>
---
 drivers/gpu/drm/tiny/appletbdrm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c
index 703b9a41a..751b05753 100644
--- a/drivers/gpu/drm/tiny/appletbdrm.c
+++ b/drivers/gpu/drm/tiny/appletbdrm.c
@@ -212,7 +212,7 @@ static int appletbdrm_read_response(struct appletbdrm_device *adev,
 	}
 
 	if (response->msg != expected_response) {
-		drm_err(drm, "Unexpected response from device (expected %p4cc found %p4cc)\n",
+		drm_err(drm, "Unexpected response from device (expected %p4cl found %p4cl)\n",
 			&expected_response, &response->msg);
 		return -EIO;
 	}
@@ -286,7 +286,7 @@ static int appletbdrm_get_information(struct appletbdrm_device *adev)
 	}
 
 	if (pixel_format != APPLETBDRM_PIXEL_FORMAT) {
-		drm_err(drm, "Encountered unknown pixel format (%p4cc)\n", &pixel_format);
+		drm_err(drm, "Encountered unknown pixel format (%p4cl)\n", &pixel_format);
 		ret = -EINVAL;
 		goto free_info;
 	}
-- 
2.47.1