linux-kernel - Re: [PATCH] drm/bridge: anx7625: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN6tsi7k=fo6V5Mqp_yOkaW25rhTYEgAdC+fCfB_72q9ObKuxw@mail.gmail.com>
Date: Wed, 12 Mar 2025 10:36:16 +0100
From: Robert Foss <rfoss@...nel.org>
To: Chen Ni <nichen@...as.ac.cn>
Cc: andrzej.hajda@...el.com, neil.armstrong@...aro.org, 
	Laurent.pinchart@...asonboard.com, jonas@...boo.se, jernej.skrabec@...il.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, lumag@...nel.org, dianders@...omium.org, 
	yuanhsinte@...omium.org, jani.nikula@...el.com, xji@...logixsemi.com, 
	robh@...nel.org, sui.jingfeng@...ux.dev, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: anx7625: Remove redundant 'flush_workqueue()' calls

On Wed, Mar 12, 2025 at 10:02 AM Chen Ni <nichen@...as.ac.cn> wrote:
>
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
>   destroy_workqueue(E);
>
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 0b97b66de577..591ec8e5b642 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2771,7 +2771,6 @@ static void anx7625_i2c_remove(struct i2c_client *client)
>
>         if (platform->hdcp_workqueue) {
>                 cancel_delayed_work(&platform->hdcp_work);
> -               flush_workqueue(platform->hdcp_workqueue);
>                 destroy_workqueue(platform->hdcp_workqueue);
>         }

Reviewed-by: Robert Foss <rfoss@...nel.org>

>
> --
> 2.25.1
>