[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPDyKFrxGzyNsr5vQjcxPRzyQMTpoR5sZjreYbO_8ZA6i_-XkA@mail.gmail.com>
Date: Wed, 12 Mar 2025 12:24:22 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Frank Li <Frank.Li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
"open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND..." <linux-mmc@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
imx@...ts.linux.dev, shawnguo@...nel.org
Subject: Re: [PATCH 1/1] dt-bindings: mmc: Change to additionalProperties to
fix fail detect Unevaluated property
On Thu, 20 Feb 2025 at 17:47, Frank Li <Frank.Li@....com> wrote:
>
> mmc-controller.yaml is common schema file. According to writing-schema.rst,
>
> * additionalProperties: true
> Rare case, used for schemas implementing common set of properties. Such
> schemas are supposed to be referenced by other schemas, which then use
> 'unevaluatedProperties: false'. Typically bus or common-part schemas.
>
> Reproduce steps:
> 1. Add unevaluated property 'abc' at example of fsl-imx-esdhc.yaml
> 2. Run make dt_binding_check DT_SCHEMA_FILES=fsl-imx-esdhc.yaml
>
> No any warning report. But suppose report below warning:
> mmc@...04000: Unevaluated properties are not allowed ('abc' was unexpected)
>
> Signed-off-by: Frank Li <Frank.Li@....com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 9d7a1298c4554..26e4f0f8dc1ce 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -24,7 +24,7 @@ properties:
> $nodename:
> pattern: "^mmc(@.*)?$"
>
> -unevaluatedProperties: true
> +additionalProperties: true
>
> examples:
> - |
> --
> 2.34.1
>
Powered by blists - more mailing lists