linux-kernel - Re: [PATCH v4 3/4] pinctrl: samsung: add gs101 specific eint suspend/resume callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <328d89da-4246-4c75-a277-b06934e4a9d9@kernel.org>
Date: Wed, 12 Mar 2025 12:56:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peter Griffin <peter.griffin@...aro.org>
Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
 andre.draszik@...aro.org, tudor.ambarus@...aro.org, willmcvicker@...gle.com,
 semen.protsenko@...aro.org, kernel-team@...roid.com,
 jaewon02.kim@...sung.com, stable@...r.kernel.org
Subject: Re: [PATCH v4 3/4] pinctrl: samsung: add gs101 specific eint
 suspend/resume callbacks

On 12/03/2025 12:39, Peter Griffin wrote:
> Hi Krzysztof,
> 
> On Wed, 12 Mar 2025 at 11:31, Peter Griffin <peter.griffin@...aro.org> wrote:
>>
>> Hi Krzysztof,
>>
>> Thanks for the review feedback.
>>
>> On Tue, 11 Mar 2025 at 19:36, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>>
>>> On 07/03/2025 11:29, Peter Griffin wrote:
>>>> gs101 differs to other SoCs in that fltcon1 register doesn't
>>>> always exist. Additionally the offset of fltcon0 is not fixed
>>>> and needs to use the newly added eint_fltcon_offset variable.
>>>>
>>>> Fixes: 4a8be01a1a7a ("pinctrl: samsung: Add gs101 SoC pinctrl configuration")
>>>> Cc: stable@...r.kernel.org
>>>
>>> It looks this depends on previous commit, right?
>>
>> Yes that's right, it depends on the refactoring in the previous patch.
>> To fix the bug (which is an Serror on suspend for gs101), we need the
>> dedicated gs101 callback so it can have the knowledge that fltcon1
>> doesn't always exist and it's varying offset.
> 
> and also dependent on the first patch that adds the eint_fltcon_offset :)


That would be fine because it's a fix as well. Ah, well, let's keep the
dependency, but then I think syntax would be:

Cc: <stable@...r.kernel.org> # depends on the previous three patches


Best regards,
Krzysztof