linux-kernel - Re: [PATCH v4] ARM: dts: nexus4: Initial dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174174398220.182780.15077964368844189000.robh@kernel.org>
Date: Tue, 11 Mar 2025 20:47:11 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: David Heidelberg <david@...t.cz>
Cc: linux-hardening@...r.kernel.org, Kees Cook <kees@...nel.org>, 
 Bjorn Andersson <andersson@...nel.org>, 
 Konrad Dybcio <konradybcio@...nel.org>, linux-kernel@...r.kernel.org, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 "Guilherme G. Piccoli" <gpiccoli@...lia.com>, linux-arm-msm@...r.kernel.org, 
 Ivan Belokobylskiy <belokobylskij@...il.com>, 
 Conor Dooley <conor+dt@...nel.org>, Tony Luck <tony.luck@...el.com>, 
 devicetree@...r.kernel.org
Subject: Re: [PATCH v4] ARM: dts: nexus4: Initial dts


On Tue, 11 Mar 2025 17:10:02 +0100, David Heidelberg wrote:
> From: Ivan Belokobylskiy <belokobylskij@...il.com>
> 
> Add initial support for LG Nexus 4 (mako).
> 
> Features currently working: regulators, eMMC, and volume keys.
> 
> Signed-off-by: Ivan Belokobylskiy <belokobylskij@...il.com>
> Co-developed-by: David Heidelberg <david@...t.cz>
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
> Changes in v4:
> - Sorted regulators and added regulators compatible.
> - Corrected pmic include and references.
> - Moved &rpm outside of / node.
> - Moved and simplify pm8921 keypad.
> - Added chasis-type.
> - Dropped incomplete WiFi node, will be provided in future
>   contributions.
> - Link to v3: https://lore.kernel.org/r/20250309-lg-nexus4-mako-v3-1-1dc2807df296@ixit.cz
> 
> Changes in v3:
> - rebased against next-20250307
> - dropped backlight until driver gets converted to DT
> 
> Changes in v2:
> - lge vendor doesn't exist anymore, rename to lg
> - sdcc@ to mmc@ to comply with dt-schema
> ---
>  arch/arm/boot/dts/qcom/Makefile                    |   1 +
>  .../boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts  | 344 +++++++++++++++++++++
>  2 files changed, 345 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/qcom/' for 20250311-lg-nexus4-mako-v4-1-3916c8ec7edb@...t.cz:

arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: hwmutex: 'reg' is a required property
	from schema $id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml#
arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: hwmutex: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml#
arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: soc: replicator: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: syscon@...0000: compatible: ['syscon'] is too short
	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#
arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: timer@...a000: 'clocks' is a required property
	from schema $id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#
arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: sps-sic-non-secure@...00000: compatible: ['syscon'] is too short
	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#
arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: rpm@...000: 'clock-controller' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpm.yaml#
arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: syscon@...0000: compatible: ['syscon'] is too short
	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#
arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: replicator: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/arm/arm,coresight-static-replicator.yaml#