linux-kernel - Re: [PATCH v2 4/4] x86: Get rid of Makefile.postlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f17b5886-8b46-4edb-9f61-7ff9b60d1b5e@suse.com>
Date: Wed, 12 Mar 2025 13:35:58 +0100
From: Petr Pavlu <petr.pavlu@...e.com>
To: Borislav Petkov <bp@...en8.de>, Ard Biesheuvel <ardb+git@...gle.com>
Cc: linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
 x86@...nel.org, Ard Biesheuvel <ardb@...nel.org>,
 Masahiro Yamada <masahiroy@...nel.org>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v2 4/4] x86: Get rid of Makefile.postlink

On 3/11/25 12:17, Borislav Petkov wrote:
> + Petr for 9d9173e9ceb6
> 
> @Petr, you can find the whole thread on lore.
> 
> On Tue, Mar 11, 2025 at 12:06:21PM +0100, Ard Biesheuvel wrote:
>> From: Ard Biesheuvel <ardb@...nel.org>
>>
>> Instead of generating the vmlinux.relocs file (needed by the
>> decompressor build to construct the KASLR relocation tables) as a
>> vmlinux postlink step, which is dubious because it depends on data that
>> is stripped from vmlinux before the build completes, generate it from
>> vmlinux.unstripped, which has been introduced specifically for this
>> purpose.
>>
>> This ensures that each artifact is rebuilt as needed, rather than as a
>> side effect of another build rule.
>>
>> This effectively reverts commit
>>
>>   9d9173e9ceb6 ("x86/build: Avoid relocation information in final vmlinux")
>>
>> Signed-off-by: Ard Biesheuvel <ardb@...nel.org>

For what it's worth, the changes look to me as an improvement over the
previous implementation.

-- 
Thanks,
Petr