linux-kernel - Re: [PATCH 0/2] selftests: livepatch: test if ftrace can trace a livepatched function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe554a6efe55d7a9fda58c3aebb56322f742b12d.camel@suse.com>
Date: Tue, 11 Mar 2025 22:53:10 -0300
From: Marcos Paulo de Souza <mpdesouza@...e.com>
To: Filipe Xavier <felipeaggger@...il.com>, Josh Poimboeuf
 <jpoimboe@...nel.org>,  Jiri Kosina <jikos@...nel.org>, Miroslav Benes
 <mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>, Joe Lawrence
 <joe.lawrence@...hat.com>, Shuah Khan <shuah@...nel.org>
Cc: live-patching@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org, felipe_life@...e.com
Subject: Re: [PATCH 0/2] selftests: livepatch: test if ftrace can trace a
 livepatched function

On Thu, 2025-03-06 at 18:51 -0300, Filipe Xavier wrote:
> This patchset add ftrace helpers functions and
> add a new test makes sure that ftrace can trace
> a function that was introduced by a livepatch.
> 
> Signed-off-by: Filipe Xavier <felipeaggger@...il.com>
> ---
> Filipe Xavier (2):
>       selftests: livepatch: add new ftrace helpers functions
>       selftests: livepatch: test if ftrace can trace a livepatched
> function
> 
>  tools/testing/selftests/livepatch/functions.sh   | 45
> ++++++++++++++++++++++++
>  tools/testing/selftests/livepatch/test-ftrace.sh | 35
> ++++++++++++++++++
>  2 files changed, 80 insertions(+)
> 

Thanks for sending this new version! One interesting thing is that you
created a new patchset, instead of iterating on the same one, and this
triggered a bug on b4[1]!

You also missed the changelog since v2, but AFAICS you addressed all
comments from me, Joe and Petr, per [2].

For the two patches:

Reviewed-by: Marcos Paulo de Souza <mpdesouza@...e.com>

[1]: https://github.com/mricon/b4/issues/58
[2]:
https://lore.kernel.org/live-patching/b2637bad-9022-496a-9b83-0d348a6350b4@gmail.com/T/#m14bc5c118490c1b17e782a0f0173c1fb70d187c7

> ---
> base-commit: 848e076317446f9c663771ddec142d7c2eb4cb43
> change-id: 20250306-ftrace-sftest-livepatch-60d9dc472235
> 
> Best regards,