linux-kernel - Re: [PATCH net v3] net: ethernet: ti: am65-cpsw: Fix NAPI registration sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80a1f61a-b2aa-414f-b446-087db7fc54a5@kernel.org>
Date: Wed, 12 Mar 2025 15:39:25 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Siddharth Vadapalli <s-vadapalli@...com>, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, horms@...nel.org, alexander.sverdlin@...mens.com,
 dan.carpenter@...aro.org, c-vankar@...com, jpanis@...libre.com,
 npitre@...libre.com
Cc: vigneshr@...com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, srk@...com
Subject: Re: [PATCH net v3] net: ethernet: ti: am65-cpsw: Fix NAPI
 registration sequence



On 11/03/2025 17:42, Siddharth Vadapalli wrote:
> From: Vignesh Raghavendra <vigneshr@...com>
> 
> Registering the interrupts for TX or RX DMA Channels prior to registering
> their respective NAPI callbacks can result in a NULL pointer dereference.
> This is seen in practice as a random occurrence since it depends on the
> randomness associated with the generation of traffic by Linux and the
> reception of traffic from the wire.
> 
> Fixes: 681eb2beb3ef ("net: ethernet: ti: am65-cpsw: ensure proper channel cleanup in error path")
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> Co-developed-by: Siddharth Vadapalli <s-vadapalli@...com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>

Reviewed-by: Roger Quadros <rogerq@...nel.org>