linux-kernel - Re: [PATCH v2] rust/kernel/faux: mark Registration methods inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <usm5gqhdi65f3vtqfgp4vwqn24omj56f7rlnomw23suo5usmi6@bzdjrfhch5gf>
Date: Tue, 11 Mar 2025 22:16:09 -0400
From: Ethan Carter Edwards <ethan@...ancedwards.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	=?utf-8?q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@...tonmail.com>, Benno Lossin <benno.lossin@...ton.me>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross <tmgross@...ch.edu>, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <nick.desaulniers+lkml@...il.com>, 
	Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH v2] rust/kernel/faux: mark Registration methods inline

On 25/03/11 08:06AM, Alice Ryhl wrote:
> On Mon, Mar 10, 2025 at 03:51:38PM -0400, Ethan Carter Edwards wrote:
> > When building the kernel on Arch Linux using on x86_64 with tools:
> > $ rustc --version
> > rustc 1.84.0 (9fc6b4312 2025-01-07)
> > $ cargo --version
> > cargo 1.84.0 (66221abde 2024-11-19)
> 
> Is there a reason you didn't drop this from the commit message?

I wasn't sure if the authoritative answer was to drop it. I will not
include it from now on. Thanks.

> 
> > $ clang --version
> > clang version 19.1.7
> > Target: x86_64-pc-linux-gnu
> > 
> > The following symbols are generated:
> > $ nm vmlinux | rg ' _R' | rustfilt | rg faux
> > ffffffff81959ae0 T <kernel::faux::Registration>::new
> > ffffffff81959b40 T <kernel::faux::Registration as core::ops::drop::Drop>::drop
> > 
> > However, these Rust symbols are wrappers around bindings in the C faux
> > code. Inlining these functions removes the middle-man wrapper function
> > After applying this patch, the above function signatures disappear.
> > 
> > Link: https://github.com/Rust-for-Linux/linux/issues/1145
> > Signed-off-by: Ethan Carter Edwards <ethan@...ancedwards.com>
> 
> On v1 I replied with:
> 
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> 
> So you should add that to the commit message when you send a new
> version. :)

My apologies. I forgot to include it, as b4 usually pulls them down for
me and I was just using format-patch and mutt to send v2. 

> 
> (Unless there are changes that require me to review it again.)
> 
> Alice

Thanks for applying the patch, Greg.

Thanks everyone for their help. Rust in the kernel isn't as scary as it
seems! I'll be back to help some more ;).