linux-kernel - Re: [PATCH v2] arm64: defconfig: mediatek: enable PHY drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5706c76e-7558-4405-a4c6-cab9cb5ddf65@notapiano>
Date: Wed, 12 Mar 2025 11:25:54 -0300
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: Vignesh Raman <vignesh.raman@...labora.com>
Cc: linux-mediatek@...ts.infradead.org, chunkuang.hu@...nel.org,
	p.zabel@...gutronix.de, angelogioacchino.delregno@...labora.com,
	krzk@...nel.org, daniels@...labora.com, airlied@...il.com,
	simona.vetter@...ll.ch, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: defconfig: mediatek: enable PHY drivers

On Wed, Mar 12, 2025 at 09:49:26AM +0530, Vignesh Raman wrote:
> The mediatek display driver fails to probe on mt8173-elm-hana and
> mt8183-kukui-jacuzzi-juniper-sku16 in v6.14-rc4 due to missing PHY
> configurations.
> 
> Enable the following PHY drivers for MediaTek platforms:
> - CONFIG_PHY_MTK_HDMI=m for HDMI display
> - CONFIG_PHY_MTK_MIPI_DSI=m for DSI display
> - CONFIG_PHY_MTK_XSPHY=m for USB
> 
> Signed-off-by: Vignesh Raman <vignesh.raman@...labora.com>
> ---
> 
> v2:
>   - Include board details in the commit message.  
>   - Sort newly added PHY configs in defconfig.
> 
> ---
>  arch/arm64/configs/defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 1f25423de383..87e8cbd3fd26 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1572,7 +1572,10 @@ CONFIG_PHY_HI6220_USB=y
>  CONFIG_PHY_HISTB_COMBPHY=y
>  CONFIG_PHY_HISI_INNO_USB2=y
>  CONFIG_PHY_MVEBU_CP110_COMPHY=y
> +CONFIG_PHY_MTK_HDMI=m
> +CONFIG_PHY_MTK_MIPI_DSI=m

This isn't the expected ordering. I imagine you manually added these configs in
the defconfig.

To get the right ordering, after you've added the configs anywhere in this
defconfig, do a 'make defconfig', then a 'make savedefconfig', and copy the
generated 'defconfig' file at the root to this location, then you can add just
this hunk to the commit, and it'll be in the correct order.

Thanks,
Nícolas