linux-kernel - Re: [PATCH] drm: xlnx: zynqmp_dpsub: fix Kconfig dependencies for ASoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c13bf2d9-51c2-40b2-af3d-ad4d5f912489@ideasonboard.com>
Date: Wed, 12 Mar 2025 16:34:27 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Arnd Bergmann <arnd@...nel.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Vishal Sagar <vishal.sagar@....com>
Cc: Arnd Bergmann <arnd@...db.de>, Jani Nikula <jani.nikula@...el.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: xlnx: zynqmp_dpsub: fix Kconfig dependencies for
 ASoC

Hi Arnd,

On 27/02/2025 15:20, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The new audio code fails to build when sounds support is in a loadable
> module but the GPU driver is built-in:
> 
> x86_64-linux-ld: zynqmp_dp_audio.c:(.text+0x6a8): undefined reference to `devm_snd_soc_register_card'
> x86_64-linux-ld: drivers/gpu/drm/xlnx/zynqmp_dp_audio.o:(.rodata+0x1bc): undefined reference to `snd_soc_info_volsw'
> x86_64-linux-ld: drivers/gpu/drm/xlnx/zynqmp_dp_audio.o:(.rodata+0x1f0): undefined reference to `snd_soc_get_volsw'
> x86_64-linux-ld: drivers/gpu/drm/xlnx/zynqmp_dp_audio.o:(.rodata+0x1f4): undefined reference to `snd_soc_put_volsw'
> 
> Change the Kconfig dependency to disallow the sound support in this
> configuration.
> 
> Fixes: 3ec5c1579305 ("drm: xlnx: zynqmp_dpsub: Add DP audio support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/gpu/drm/xlnx/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xlnx/Kconfig b/drivers/gpu/drm/xlnx/Kconfig
> index dbecca9bdd54..cfabf5e2a0bb 100644
> --- a/drivers/gpu/drm/xlnx/Kconfig
> +++ b/drivers/gpu/drm/xlnx/Kconfig
> @@ -22,6 +22,7 @@ config DRM_ZYNQMP_DPSUB_AUDIO
>   	bool "ZynqMP DisplayPort Audio Support"
>   	depends on DRM_ZYNQMP_DPSUB
>   	depends on SND && SND_SOC
> +	depends on SND_SOC=y || DRM_ZYNQMP_DPSUB=m
>   	select SND_SOC_GENERIC_DMAENGINE_PCM
>   	help
>   	  Choose this option to enable DisplayPort audio support in the ZynqMP

Thanks, pushing to drm-misc-next.

  Tomi