linux-kernel - Re: [PATCH v2 1/3] dt-bindings: mtd: microchip-nand: convert txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e459cf3c-5ad1-40c8-a2f9-d766584d4cd9@microchip.com>
Date: Wed, 12 Mar 2025 02:46:13 +0000
From: <Balamanikandan.Gunasundar@...rochip.com>
To: <robh@...nel.org>
CC: <linux-mtd@...ts.infradead.org>, <krzysztof.kozlowski+dt@...aro.org>,
	<linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
	<richard@....at>, <miquel.raynal@...tlin.com>, <krzk+dt@...nel.org>,
	<claudiu.beznea@...on.dev>, <vigneshr@...com>,
	<linux-kernel@...r.kernel.org>, <Nicolas.Ferre@...rochip.com>,
	<conor+dt@...nel.org>, <alexandre.belloni@...tlin.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: mtd: microchip-nand: convert txt to
 yaml

Hi Rob,

On 11/03/25 8:22 pm, Rob Herring (Arm) wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Tue, 11 Mar 2025 17:58:45 +0530, Balamanikandan Gunasundar wrote:
>> Convert text to yaml for microchip nand controller
>>
>> Signed-off-by: Balamanikandan Gunasundar <balamanikandan.gunasundar@...rochip.com>
>> ---
>>
>> Changes in v2:
>>
>> - Change the filename to match the compatible string
>> - Drop items and oneOf in the compatible property as it is just an enum
>> - Remove the if in the #address-cells and #size-cells
>> - Remove the unwanted comments that refers to .txt files
>> - Fix reg property description
>> - Define the properties in a list and add constraints
>> - Fix DT coding style and droped unused labels
>>
>>   .../devicetree/bindings/mtd/atmel-nand.txt    |  50 -----
>>   .../mtd/microchip,nand-controller.yaml        | 175 ++++++++++++++++++
>>   2 files changed, 175 insertions(+), 50 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/mtd/microchip,nand-controller.yaml
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/mtd/microchip,nand-controller.example.dtb: /example-0/ecc-engine@...fc070: failed to match any schema with compatible: ['atmel,at91sam9g45-pmecc']
> Documentation/devicetree/bindings/mtd/microchip,nand-controller.example.dtb: /example-0/ebi@...00000: failed to match any schema with compatible: ['atmel,sama5d3-ebi']
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/microchip,nand-controller.example.dtb: nand-controller: #address-cells: 1 was expected
>          from schema $id: http://devicetree.org/schemas/mtd/nand-controller.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/microchip,nand-controller.example.dtb: nand-controller: #size-cells: 0 was expected
>          from schema $id: http://devicetree.org/schemas/mtd/nand-controller.yaml#
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250311122847.90081-2-balamanikandan.gunasundar@microchip.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:

Yes I made sure I ran dt_binding_check and dtbs_check before sending and 
didn't see the errors. As you said I will update the dt-schema and check 
again. Will address the other comments for this series and send a v3.

Thanks,
Bala

> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>