linux-kernel - Re: linux-next: build failure after merge of the mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250312082452.604def384a3adf379625cacb@linux-foundation.org>
Date: Wed, 12 Mar 2025 08:24:52 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Wei Yang <richard.weiyang@...il.com>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>, Shuah Khan <shuah@...nel.org>
Subject: Re: linux-next: build failure after merge of the mm tree

On Wed, 12 Mar 2025 11:36:12 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> After merging the mm tree, today's linux-next build (native powerpc perf)
> failed like this:
> 
> In file included from arch/powerpc/util/../../../util/pmu.h:5,
>                  from arch/powerpc/util/pmu.c:5:
> tools/include/linux/bitmap.h: In function 'bitmap_alloc':
> tools/include/linux/bitmap.h:83:69: error: unused parameter 'flags' [-Werror=unused-parameter]
>    83 | static inline unsigned long *bitmap_alloc(unsigned int nbits, gfp_t flags)
>       |                                                               ~~~~~~^~~~~
> cc1: all warnings being treated as errors

Maybe we should turn off -Wno-unused-parameter for tools/.  The rest of
the kernel extensively expects that unused parameters to inlined
functions are acceptable, for stuff like this:

#else /* CONFIG_SWAP */
static inline struct swap_info_struct *swp_swap_info(swp_entry_t entry)
{
	return NULL;
}

static inline struct swap_info_struct *get_swap_device(swp_entry_t entry)
{
	return NULL;
}

static inline void put_swap_device(struct swap_info_struct *si)
{
}

so why do we make tools/ different?