linux-kernel - Re: [PATCH v8 4/4] Documentation/serial-console: Document CONFIG_NULL_TTY_DEFAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9Gq-oIr8wPGLGEy@pathway.suse.cz>
Date: Wed, 12 Mar 2025 16:40:42 +0100
From: Petr Mladek <pmladek@...e.com>
To: adamsimonelli@...il.com
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jiri Slaby <jirislaby@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: [PATCH v8 4/4] Documentation/serial-console: Document
 CONFIG_NULL_TTY_DEFAULT_CONSOLE.

On Mon 2025-03-10 23:31:33, adamsimonelli@...il.com wrote:
> From: Adam Simonelli <adamsimonelli@...il.com>
> 
> When the kernel is compiled with CONFIG_NULL_TTY_DEFAULT_CONSOLE and
> no console= options are selected, it defaults to using the ttynull
> device.

There is a missing Signed-off-by.

The change looks fine to me. Feel free to use:

Reviewed-by: Petr Mladek <pmladek@...e.com>

That said, I would personally squash this into the patch adding
the CONFIG_NULL_TTY_DEFAULT_CONSOLE configure option.

Best Regards,
Petr