linux-kernel - Re: [PATCH] wifi: iwlwifi: Fix uninitialized variable with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b32cd5b-aa46-4a23-bd21-908196c4bab3@web.de>
Date: Wed, 12 Mar 2025 16:42:18 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Dan Carpenter <dan.carpenter@...aro.org>, linux-wireless@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Anjaneyulu <pagadala.yesu.anjaneyulu@...el.com>,
 Avraham Stern <avraham.stern@...el.com>,
 Daniel Gabay <daniel.gabay@...el.com>,
 Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
 Jeff Johnson <jeff.johnson@....qualcomm.com>,
 Johannes Berg <johannes.berg@...el.com>,
 Miriam Rachel Korenblit <miriam.rachel.korenblit@...el.com>,
 Yedidya Benshimol <yedidya.ben.shimol@...el.com>
Subject: Re: [PATCH] wifi: iwlwifi: Fix uninitialized variable with __free()

…
> +++ b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
> @@ -556,8 +556,8 @@ iwl_dbgfs_vif_twt_setup_write(struct iwl_mld *mld, char *buf, size_t count,
>  	};
>  	struct ieee80211_vif *vif = data;
>  	struct iwl_mld_vif *mld_vif = iwl_mld_vif_from_mac80211(vif);
> +	struct iwl_dhc_cmd *cmd __free(kfree) = NULL;
>  	struct iwl_dhc_twt_operation *dhc_twt_cmd;
> -	struct iwl_dhc_cmd *cmd __free(kfree);
…

Can it be recommended to reduce the scope for the affected local variable instead?
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/cleanup.h#L129-L133

Regards,
Markus