linux-kernel - Re: [PATCH 1/2] x86/coco/sev: Move SEV SYSFS group to /sys/hypervisor/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9GrsoIP_NWjPPC-@8bytes.org>
Date: Wed, 12 Mar 2025 16:43:46 +0100
From: Joerg Roedel <joro@...tes.org>
To: Liam Merwick <liam.merwick@...cle.com>
Cc: x86@...nel.org, hpa@...or.com, Tom Lendacky <thomas.lendacky@....com>,
	Nikunj A Dadhania <nikunj@....com>, Larry.Dewey@....com,
	linux-kernel@...r.kernel.org, linux-coco@...ts.linux.dev,
	Juergen Gross <jgross@...e.com>, kirill.shutemov@...ux.intel.com,
	alexey.gladkov@...el.com, Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH 1/2] x86/coco/sev: Move SEV SYSFS group to
 /sys/hypervisor/

On Wed, Mar 12, 2025 at 03:32:04PM +0000, Liam Merwick wrote:
> one suggestion below but either way,
> 
> Reviewed-by: Liam Merwick <liam.merwick@...cle.com>

Thanks!

> > +	sev_kobj = kobject_create_and_add("sev", hypervisor_kobj);
> 
> Given hypervisor_kobj is created elsewhere, and the caller of
> hypervisor_init() doesn't check for ENOMEM, would it be worth
> adding a check here that it exists before using it?

Hmm, dunno, I guess it would make things slightly more robust. On the
other side all existing users of this object already assume a successful
initialization.

Regards,

	Joerg