linux-kernel - Re: [PATCH] bus: fsl-mc: Remove deadcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9Lj9_yM1EK5pKee@gallifrey>
Date: Thu, 13 Mar 2025 13:56:07 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: gregkh@...uxfoundation.org, Ioana Ciornei <ioana.ciornei@....com>
Cc: Christophe Leroy <christophe.leroy@...roup.eu>, stuyoder@...il.com,
	Laurentiu Tudor <laurentiu.tudor@....com>,
	linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: fsl-mc: Remove deadcode

Hi Greg,

* Ioana Ciornei (ioana.ciornei@....com) wrote:
> On Thu, Mar 13, 2025 at 02:37:56PM +0100, Christophe Leroy wrote:
> > 
> > 
> > Le 13/03/2025 à 14:21, Dr. David Alan Gilbert a écrit :
> > > [Vous ne recevez pas souvent de courriers de linux@...blig.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> > > 
> > > * Christophe Leroy (christophe.leroy@...roup.eu) wrote:
> > > > 
> > > > 
> > > > Le 15/11/2024 à 16:20, linux@...blig.org a écrit :
> > > > > [Vous ne recevez pas souvent de courriers de linux@...blig.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> > > > > 
> > > > > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > > > > 
> > > > > fsl_mc_allocator_driver_exit() was added explicitly by
> > > > > commit 1e8ac83b6caf ("bus: fsl-mc: add fsl_mc_allocator cleanup function")
> > > > > but was never used.
> > > > > 
> > > > > Remove it.
> > > > > 
> > > > > fsl_mc_portal_reset() was added in 2015 by
> > > > > commit 197f4d6a4a00 ("staging: fsl-mc: fsl-mc object allocator driver")
> > > > > but was never used.
> > > > > 
> > > > > Remove it.
> > > > > 
> > > > > fsl_mc_portal_reset() was the only caller of dpmcp_reset().
> > > > > 
> > > > > Remove it.
> > > > > 
> > > > > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > > > 
> > > > Acked-by: Christophe Leroy <christophe.leroy@...roup.eu>
> > > 
> > > Hi,
> > >    Can someone pick this old change up please?  I see the PPC patchwork says
> > >    'handled elsewhere' but doesn't say where.
> > 
> > MAINTAINERS file says where:
> > 
> > QORIQ DPAA2 FSL-MC BUS DRIVER
> > M:	Stuart Yoder <stuyoder@...il.com>
> > M:	Laurentiu Tudor <laurentiu.tudor@....com>
> > L:	linux-kernel@...r.kernel.org
> > S:	Maintained
> > F:	Documentation/ABI/stable/sysfs-bus-fsl-mc
> > F:	Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt
> > F:
> > Documentation/networking/device_drivers/ethernet/freescale/dpaa2/overview.rst
> > F:	drivers/bus/fsl-mc/
> > F:	include/uapi/linux/fsl_mc.h
> > 
> > FREESCALE SOC DRIVERS
> > M:	Christophe Leroy <christophe.leroy@...roup.eu>
> > L:	linuxppc-dev@...ts.ozlabs.org
> > L:	linux-arm-kernel@...ts.infradead.org (moderated for non-subscribers)
> > S:	Maintained
> > F:	Documentation/devicetree/bindings/misc/fsl,dpaa2-console.yaml
> > F:	Documentation/devicetree/bindings/soc/fsl/
> > F:	drivers/soc/fsl/
> > F:	include/linux/fsl/
> > F:	include/soc/fsl/
> > 
> > I acked the 2 line changes in include/linux/fsl/mc.h, the main changes being
> > in the C files which are not under my scope.
> > 
> > Stuart, Laurentiu, can you pick up the patch ?
> 
> Stuart and Laurentiu are no longer at NXP. Even when they handled the
> fsl-mc bus driver, they didn't have a tree themselves to pick patches up
> but rather, historically, patches on the fsl-mc bus were picked by Greg
> KH.

OK, copied Greg in.

Dave

> Ioana
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/