linux-kernel - Re: [patch 3/7] soc: dove: Convert generic irqchip locking to guard()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3860ac63-3181-4d00-8824-6d122e195176@lunn.ch>
Date: Thu, 13 Mar 2025 15:48:20 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>, Jiri Slaby <jirislaby@...nel.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Gregory Clement <gregory.clement@...tlin.com>,
	Uwe Kleine-König <ukleinek@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Talel Shenhar <talel@...zon.com>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Guo Ren <guoren@...nel.org>,
	Herve Codina <herve.codina@...tlin.com>,
	Huacai Chen <chenhuacai@...nel.org>,
	Jiaxun Yang <jiaxun.yang@...goat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Chen-Yu Tsai <wens@...e.org>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Samuel Holland <samuel@...lland.org>
Subject: Re: [patch 3/7] soc: dove: Convert generic irqchip locking to guard()

On Thu, Mar 13, 2025 at 03:31:21PM +0100, Thomas Gleixner wrote:
> Conversion was done with Coccinelle. No functional change.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> Cc: Gregory Clement <gregory.clement@...tlin.com>
> ---
>  drivers/soc/dove/pmu.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/soc/dove/pmu.c
> +++ b/drivers/soc/dove/pmu.c
> @@ -257,10 +257,9 @@ static void pmu_irq_handler(struct irq_d
>  	 * So, let's structure the code so that the window is as small as
>  	 * possible.
>  	 */
> -	irq_gc_lock(gc);
> +	guard(raw_spinlock)(&gc->lock);
>  	done &= readl_relaxed(base + PMC_IRQ_CAUSE);
>  	writel_relaxed(done, base + PMC_IRQ_CAUSE);
> -	irq_gc_unlock(gc);
>  }

My personal preference would be a scoped_guard() rather than this
magical guard() construct which looks nothing like C. But whatever.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew