| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202503132205.Vf8imlWS-lkp@intel.com>
Date: Thu, 13 Mar 2025 22:53:55 +0800
From: kernel test robot <lkp@...el.com>
To: Subu Dwevedi <messigoatcr7nop@...il.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
Subu Dwevedi <messigoatcr7nop@...il.com>,
Henrik Rydberg <rydberg@...math.org>,
Jean Delvare <jdelvare@...e.com>,
Guenter Roeck <linux@...ck-us.net>, linux-hwmon@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] hwmon/applesmc: add fan support for newer macs
Hi Subu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on linus/master v6.14-rc6 next-20250313]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Subu-Dwevedi/hwmon-applesmc-add-MMIO-for-newer-macs/20250312-203248
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link: https://lore.kernel.org/r/20250312123055.1735-3-messigoatcr7nop%40gmail.com
patch subject: [PATCH 2/2] hwmon/applesmc: add fan support for newer macs
config: i386-randconfig-002-20250313 (https://download.01.org/0day-ci/archive/20250313/202503132205.Vf8imlWS-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250313/202503132205.Vf8imlWS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503132205.Vf8imlWS-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/hwmon/applesmc.c: In function 'applesmc_show_fan_manual':
>> drivers/hwmon/applesmc.c:1155:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
1155 | int ret;
| ^~~
vim +/ret +1155 drivers/hwmon/applesmc.c
6f2fad748ccced5 Nicolas Boichat 2007-05-08 1151
6f2fad748ccced5 Nicolas Boichat 2007-05-08 1152 static ssize_t applesmc_show_fan_manual(struct device *dev,
3eba2bf7c5fb786 Henrik Rydberg 2010-11-09 1153 struct device_attribute *attr, char *sysfsbuf)
6f2fad748ccced5 Nicolas Boichat 2007-05-08 1154 {
6f2fad748ccced5 Nicolas Boichat 2007-05-08 @1155 int ret;
6f2fad748ccced5 Nicolas Boichat 2007-05-08 1156 u16 manual = 0;
6f2fad748ccced5 Nicolas Boichat 2007-05-08 1157 u8 buffer[2];
6f2fad748ccced5 Nicolas Boichat 2007-05-08 1158
beab9ce267efe06 Subu Dwevedi 2025-03-12 1159 if (is_fan_manual_fmt) {
beab9ce267efe06 Subu Dwevedi 2025-03-12 1160 ret = applesmc_read_key(FANS_MANUAL_FMT, buffer, 1);
beab9ce267efe06 Subu Dwevedi 2025-03-12 1161 manual = buffer[0];
beab9ce267efe06 Subu Dwevedi 2025-03-12 1162 } else {
6f2fad748ccced5 Nicolas Boichat 2007-05-08 1163 ret = applesmc_read_key(FANS_MANUAL, buffer, 2);
cecf7560f00a841 Tom Rix 2020-08-20 1164 manual = ((buffer[0] << 8 | buffer[1]) >> to_index(attr)) & 0x01;
beab9ce267efe06 Subu Dwevedi 2025-03-12 1165 }
1f4d4af4d7a1c79 Guenter Roeck 2021-03-21 1166 return sysfs_emit(sysfsbuf, "%d\n", manual);
6f2fad748ccced5 Nicolas Boichat 2007-05-08 1167 }
6f2fad748ccced5 Nicolas Boichat 2007-05-08 1168
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists