linux-kernel - Re: [PATCH 0/3] Export the target RPM fan control by ChromeOS EC under hwmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df6f96a1-66f0-4a83-a543-f71ca8d37eed@t-8ch.de>
Date: Thu, 13 Mar 2025 17:16:03 +0100
From: Thomas Weißschuh <thomas@...ssschuh.net>
To: Sung-Chi Li <lschyi@...omium.org>
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>, 
	Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>, 
	chrome-platform@...ts.linux.dev, linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Export the target RPM fan control by ChromeOS EC
 under hwmon

Hi Sung-Chi,

On 2025-03-13 12:47:41+0800, Sung-Chi Li wrote:
> ChromeOS embedded controller (EC) supports closed-loop fan control. We
> anticipate to have the fan related control from the kernel side, so this
> series register the HWMON_F_TARGET attribute, and implement the read and
> write function for setting/reading the target fan RPM from the EC side.

In general the idea is fine. I'll post some comments for the patches.

The series should be squashed into a single patch. All the new code is
closely related to each other.

> Signed-off-by: Sung-Chi Li <lschyi@...omium.org>
> ---
> Sung-Chi Li (3):
>       hwmon: (cros_ec) Add setting target fan RPM function
>       hwmon: (cros_ec) Add reading target fan RPM function
>       hwmon: (cros_ec) Register fan target attribute
> 
>  drivers/hwmon/cros_ec_hwmon.c | 69 +++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 64 insertions(+), 5 deletions(-)
> ---
> base-commit: 9fbcd7b32bf7c0a5bda0f22c25df29d00a872017
> change-id: 20250313-extend_ec_hwmon_fan-a5f59aab2cb3
> 
> Best regards,
> -- 
> Sung-Chi Li <lschyi@...omium.org>