linux-kernel - Re: [PATCH 7/7] coresight: Remove extern from function declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250313161702.GT9682@e132581.arm.com>
Date: Thu, 13 Mar 2025 16:17:02 +0000
From: Leo Yan <leo.yan@....com>
To: James Clark <james.clark@...aro.org>
Cc: lcherian@...vell.com, coresight@...ts.linaro.org,
	Mike Leach <mike.leach@...aro.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 7/7] coresight: Remove extern from function declarations

On Tue, Feb 11, 2025 at 10:39:43AM +0000, James Clark wrote:
> 
> Function declarations are extern by default so remove the extra noise
> and inconsistency.

This change is consistent with the coding-style.rst:

  "Do not use the ``extern`` keyword with function declarations as
   this makes lines longer and isn't strictly necessary."

Reviewed-by: Leo Yan <leo.yan@....com>

> Signed-off-by: James Clark <james.clark@...aro.org>
> ---
>  drivers/hwtracing/coresight/coresight-priv.h | 14 ++++-----
>  include/linux/coresight.h                    | 33 +++++++++-----------
>  2 files changed, 21 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h
> index a83113225797..e09071a720f0 100644
> --- a/drivers/hwtracing/coresight/coresight-priv.h
> +++ b/drivers/hwtracing/coresight/coresight-priv.h
> @@ -57,10 +57,8 @@ struct cs_off_attribute {
>         u32 off;
>  };
> 
> -extern ssize_t coresight_simple_show32(struct device *_dev,
> -                                    struct device_attribute *attr, char *buf);
> -extern ssize_t coresight_simple_show_pair(struct device *_dev,
> -                                    struct device_attribute *attr, char *buf);
> +ssize_t coresight_simple_show32(struct device *_dev, struct device_attribute *attr, char *buf);
> +ssize_t coresight_simple_show_pair(struct device *_dev, struct device_attribute *attr, char *buf);
> 
>  #define coresight_simple_reg32(name, offset)                           \
>         (&((struct cs_off_attribute[]) {                                \
> @@ -155,8 +153,8 @@ void coresight_remove_links(struct coresight_device *orig,
>  u32 coresight_get_sink_id(struct coresight_device *csdev);
> 
>  #if IS_ENABLED(CONFIG_CORESIGHT_SOURCE_ETM3X)
> -extern int etm_readl_cp14(u32 off, unsigned int *val);
> -extern int etm_writel_cp14(u32 off, u32 val);
> +int etm_readl_cp14(u32 off, unsigned int *val);
> +int etm_writel_cp14(u32 off, u32 val);
>  #else
>  static inline int etm_readl_cp14(u32 off, unsigned int *val) { return 0; }
>  static inline int etm_writel_cp14(u32 off, u32 val) { return 0; }
> @@ -167,8 +165,8 @@ struct cti_assoc_op {
>         void (*remove)(struct coresight_device *csdev);
>  };
> 
> -extern void coresight_set_cti_ops(const struct cti_assoc_op *cti_op);
> -extern void coresight_remove_cti_ops(void);
> +void coresight_set_cti_ops(const struct cti_assoc_op *cti_op);
> +void coresight_remove_cti_ops(void);
> 
>  /*
>   * Macros and inline functions to handle CoreSight UCI data and driver
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index 11808aee9d1d..2b43698c0b25 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -642,26 +642,23 @@ static inline void coresight_set_mode(struct coresight_device *csdev,
>         local_set(&csdev->mode, new_mode);
>  }
> 
> -extern struct coresight_device *
> -coresight_register(struct coresight_desc *desc);
> -extern void coresight_unregister(struct coresight_device *csdev);
> -extern int coresight_enable_sysfs(struct coresight_device *csdev);
> -extern void coresight_disable_sysfs(struct coresight_device *csdev);
> -extern int coresight_timeout(struct csdev_access *csa, u32 offset,
> -                            int position, int value);
> -
> -extern int coresight_claim_device(struct coresight_device *csdev);
> -extern int coresight_claim_device_unlocked(struct coresight_device *csdev);
> -
> -extern void coresight_disclaim_device(struct csdev_access *csa);
> -extern void coresight_disclaim_device_unlocked(struct csdev_access *csa);
> +struct coresight_device *coresight_register(struct coresight_desc *desc);
> +void coresight_unregister(struct coresight_device *csdev);
> +int coresight_enable_sysfs(struct coresight_device *csdev);
> +void coresight_disable_sysfs(struct coresight_device *csdev);
> +int coresight_timeout(struct csdev_access *csa, u32 offset, int position, int value);
> +
> +int coresight_claim_device(struct coresight_device *csdev);
> +int coresight_claim_device_unlocked(struct coresight_device *csdev);
> +
> +void coresight_disclaim_device(struct csdev_access *csa);
> +void coresight_disclaim_device_unlocked(struct csdev_access *csa);
>  int coresight_reset_claim_unlocked(struct csdev_access *csa);
>  int coresight_reset_claim(struct csdev_access *csa);
> 
> -extern char *coresight_alloc_device_name(struct coresight_dev_list *devs,
> -                                        struct device *dev);
> +char *coresight_alloc_device_name(struct coresight_dev_list *devs, struct device *dev);
> 
> -extern bool coresight_loses_context_with_cpu(struct device *dev);
> +bool coresight_loses_context_with_cpu(struct device *dev);
> 
>  u32 coresight_relaxed_read32(struct coresight_device *csdev, u32 offset);
>  u32 coresight_read32(struct coresight_device *csdev, u32 offset);
> @@ -674,8 +671,8 @@ void coresight_relaxed_write64(struct coresight_device *csdev,
>                                u64 val, u32 offset);
>  void coresight_write64(struct coresight_device *csdev, u64 val, u32 offset);
> 
> -extern int coresight_get_cpu(struct device *dev);
> -extern int coresight_get_static_trace_id(struct device *dev, u32 *id);
> +int coresight_get_cpu(struct device *dev);
> +int coresight_get_static_trace_id(struct device *dev, u32 *id);
> 
>  struct coresight_platform_data *coresight_get_platform_data(struct device *dev);
>  struct coresight_connection *
> --
> 2.34.1
> 
> _______________________________________________
> CoreSight mailing list -- coresight@...ts.linaro.org
> To unsubscribe send an email to coresight-leave@...ts.linaro.org