linux-kernel - Re: [PATCH net-next 10/16] idpf: add support for nointerrupt queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e29e48e7-cc5e-4f32-ad99-d685fef9eb79@intel.com>
Date: Thu, 13 Mar 2025 17:19:31 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, Michal Kubiak
	<michal.kubiak@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, "Przemek
 Kitszel" <przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Alexei
 Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
	"Jesper Dangaard Brouer" <hawk@...nel.org>, John Fastabend
	<john.fastabend@...il.com>, Simon Horman <horms@...nel.org>,
	<bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 10/16] idpf: add support for nointerrupt queues

From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Date: Fri, 7 Mar 2025 13:10:29 +0100

> On Wed, Mar 05, 2025 at 05:21:26PM +0100, Alexander Lobakin wrote:
>> Currently, queues are associated 1:1 with interrupt vectors as it's
>> assumed queues are always interrupt-driven.
>> In order to use a queue without an interrupt, idpf still needs to have
>> a vector assigned to it to flush descriptors. This vector can be global
>> and only one for the whole vport to handle all its noirq queues.
>> Always request one excessive vector and configure it in non-interrupt
>> mode right away when creating vport, so that it can be used later by
>> queues when needed.
> 
> Description sort of miss the purpose of this commit, you don't ever
> mention that your design choice for XDP Tx queues is to have them
> irq-less.

Because this is not directly related to XDP and maybe some time later
more code could make use of noirq queues, who knows :>

But I'll mention why this is needed, ok.

> 
>>
>> Co-developed-by: Michal Kubiak <michal.kubiak@...el.com>
>> Signed-off-by: Michal Kubiak <michal.kubiak@...el.com>
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
>> ---
>>  drivers/net/ethernet/intel/idpf/idpf.h        |  8 +++
>>  drivers/net/ethernet/intel/idpf/idpf_txrx.h   |  4 ++
>>  drivers/net/ethernet/intel/idpf/idpf_dev.c    | 11 +++-
>>  drivers/net/ethernet/intel/idpf/idpf_lib.c    |  2 +-
>>  drivers/net/ethernet/intel/idpf/idpf_txrx.c   |  8 +++
>>  drivers/net/ethernet/intel/idpf/idpf_vf_dev.c | 11 +++-
>>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 53 +++++++++++++------
>>  7 files changed, 79 insertions(+), 18 deletions(-)

Thanks,
Olek