linux-kernel - Re: [PATCH v3 2/8] mfd: stm32-lptimer: add support for stm32mp25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250313164008.GC3645863@google.com>
Date: Thu, 13 Mar 2025 16:40:08 +0000
From: Lee Jones <lee@...nel.org>
To: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
Cc: ukleinek@...nel.org, alexandre.torgue@...s.st.com, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, jic23@...nel.org,
	daniel.lezcano@...aro.org, tglx@...utronix.de,
	catalin.marinas@....com, will@...nel.org,
	devicetree@...r.kernel.org, wbg@...nel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org, linux-pwm@...r.kernel.org,
	olivier.moysan@...s.st.com
Subject: Re: [PATCH v3 2/8] mfd: stm32-lptimer: add support for stm32mp25

On Wed, 05 Mar 2025, Fabrice Gasnier wrote:

> Add support for STM32MP25 SoC.
> A new hardware configuration register (HWCFGR2) has been added, to gather
> number of capture/compare channels, autonomous mode and input capture
> capability. The full feature set is implemented in LPTIM1/2/3/4. LPTIM5
> supports a smaller set of features. This can now be read from HWCFGR
> registers.
> 
> Add new registers to the stm32-lptimer.h: CCMR1, CCR2, HWCFGR1/2 and VERR.
> Update the stm32_lptimer data struct so signal the number of
> capture/compare channels to the child devices.
> Also Remove some unused bit masks (CMPOK_ARROK / CMPOKCF_ARROKCF).
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
> ---
> Changes in V2:
> - rely on fallback compatible as no specific .data is associated to the
>   driver. Compatibility is added by reading hardware configuration
>   registers.
> - read version register, to be used by clockevent child driver
> - rename register/bits definitions
> ---
>  drivers/mfd/stm32-lptimer.c       | 33 ++++++++++++++++++++++++++++-

Looks okay.

>  include/linux/mfd/stm32-lptimer.h | 35 ++++++++++++++++++++++++++++---

Assumingly this patch is not independent of the others?

-- 
Lee Jones [李琼斯]