linux-kernel - Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN3PR01MB95972EFA147FB0453D5A7FABB8D32@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
Date: Thu, 13 Mar 2025 17:42:10 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Kees Cook <kees@...nel.org>
CC: Petr Mladek <pmladek@...e.com>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>, Sven Peter <sven@...npeter.dev>, Thomas
 Zimmermann <tzimmermann@...e.de>, Aun-Ali Zaidi <admin@...eit.net>, Maxime
 Ripard <mripard@...nel.org>, "airlied@...hat.com" <airlied@...hat.com>,
	Simona Vetter <simona@...ll.ch>, Steven Rostedt <rostedt@...dmis.org>, Rasmus
 Villemoes <linux@...musvillemoes.dk>, Sergey Senozhatsky
	<senozhatsky@...omium.org>, Jonathan Corbet <corbet@....net>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, "apw@...onical.com"
	<apw@...onical.com>, "joe@...ches.com" <joe@...ches.com>,
	"dwaipayanray1@...il.com" <dwaipayanray1@...il.com>,
	"lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>, Linux Kernel Mailing
 List <linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, Hector Martin <marcan@...can.st>,
	"asahi@...ts.linux.dev" <asahi@...ts.linux.dev>
Subject: Re: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by
 extending %p4cc

Hi

> On 13 Mar 2025, at 11:10 PM, Kees Cook <kees@...nel.org> wrote:
> 
> On Thu, Mar 13, 2025 at 11:48:32AM +0100, Petr Mladek wrote:
>> So I am fine with this patch:
>> 
>> Reviewed-by: Petr Mladek <pmladek@...e.com>
>> Tested-by: Petr Mladek <pmladek@...e.com>
>> 
>> 
>> Now, the question is how to get this patch into the mainline.
>> 
>> Normally, it would make perfect sense to queue it via the DRM tree
>> because drivers/gpu/drm/tiny/appletbdrm.c is a new driver...
>> 
>> But this time there is a conflicting patchset which is reworking
>> the entire lib/test_printf.c file, see
>> 20250307-printf-kunit-convert-v6-0-4d85c361c241@...il.com
>> And it will likely be ready for the next merge window as well.
>> I am going to review it right away.
>> 
>> It is even more complicated because the patchset converting
>> the printf test module to KUNIT depends on another changes
>> in Kees' tree (moving kunit test modules to lib/tests/).
>> So it might be easier when it goes via Kees' tree.
>> 
>> And it might be easier when even this patch goes via Kees' tree.
>> 
>> My proposal:
>> 
>> I suggest to separate the fourcc_pointer() test update
>> to a separate patch and add it later after the merge window
>> when things settle down.
>> 
>> I mean to send the vsprintf.c, checkpatch.pl, and doc update
>> via DRM tree together with the new appletbdrm.c driver.
>> 
>> And update the selftest later when both DRM tree and KUNIT
>> update reaches mainline.
>> 
>> How does that sound, please?
> 
> I'm happy to do whatever makes this easiest.
> 
> If patch #1 here were rebased onto the "kunit move" tree:
> https://web.git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/move-kunit-tests
> then I could just take it there?

I already sent the 1st patch to DRM. I can rebase the test-printf bit to this tree. Sounds good?