linux-kernel - Re: [PATCH v4] scsi: ufs: critical health condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0991bf65-aa76-46b1-b353-2a19069426d1@acm.org>
Date: Thu, 13 Mar 2025 11:13:51 -0700
From: Bart Van Assche <bvanassche@....org>
To: Avri Altman <avri.altman@....com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] scsi: ufs: critical health condition

On 2/10/25 10:58 PM, Avri Altman wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index cd404ade48dc..ef56a5eb52dc 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -6216,6 +6216,11 @@ static void ufshcd_exception_event_handler(struct work_struct *work)
>   	if (status & hba->ee_drv_mask & MASK_EE_URGENT_TEMP)
>   		ufshcd_temp_exception_event_handler(hba, status);
>   
> +	if (status & hba->ee_drv_mask & MASK_EE_HEALTH_CRITICAL) {
> +		hba->critical_health_count++;
> +		sysfs_notify(&hba->dev->kobj, NULL, "critical_health");
> +	}
> +
>   	ufs_debugfs_exception_event(hba, status);
>   }

Hi Avri,

sysfs_notify() may sleep and hence must not be called from an interrupt
handler. Please fix.

Thanks,

Bart.