linux-kernel - Re: [PATCH v2 2/2] regulator: check that dummy regulator has been probed before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=V9WRjcxfYRtBWUe+twqjqkmW4r_oZYo2xJ4PctXgBQxw@mail.gmail.com>
Date: Wed, 12 Mar 2025 17:46:43 -0700
From: Doug Anderson <dianders@...omium.org>
To: Christian Eggers <ceggers@...i.de>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: check that dummy regulator has been
 probed before using it

Hi,

On Tue, Mar 11, 2025 at 2:18 AM Christian Eggers <ceggers@...i.de> wrote:
>
> @@ -2213,6 +2221,8 @@ struct regulator *_regulator_get_common(struct regulator_dev *rdev, struct devic
>                          */
>                         dev_warn(dev, "supply %s not found, using dummy regulator\n", id);
>                         rdev = dummy_regulator_rdev;
> +                       if (!rdev)
> +                               return ERR_PTR(-EPROBE_DEFER);

nit: it feels like the dev_warn() above should be below your new
check. Otherwise you'll get the same message again after the deferral
processes.