linux-kernel - Re: [PATCH] thermal: int340x: Add Null check for adev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iMs7tsu+XXQbO=NoEY=zf1YRbJ8SFP+FAWyVVxFs=xxg@mail.gmail.com>
Date: Thu, 13 Mar 2025 21:48:07 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>, 
	Chenyuan Yang <chenyuan0y@...il.com>
Cc: daniel.lezcano@...aro.org, rui.zhang@...el.com, lukasz.luba@....com, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: int340x: Add Null check for adev

On Thu, Mar 13, 2025 at 9:37 AM Uwe Kleine-König
<u.kleine-koenig@...libre.com> wrote:
>
> Hello,
>
> On Wed, Mar 12, 2025 at 11:36:11PM -0500, Chenyuan Yang wrote:
> > Not all devices have an ACPI companion fwnode, so adev might be NULL.
> > This is similar to the commit cd2fd6eab480
> > ("platform/x86: int3472: Check for adev == NULL").
> >
> > Add a check for adev not being set and return -ENODEV in that case to
> > avoid a possible NULL pointer deref in int3402_thermal_probe().
> >
> > Note, under the same directory, int3400_thermal_probe() has such a
> > check.
> >
> > Signed-off-by: Chenyuan Yang <chenyuan0y@...il.com>
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> Fixes: 77e337c6e23e ("Thermal: introduce INT3402 thermal driver")

Applied as 6.15 material, thanks!